From a56fc3403909daa6710bf7e2bd641051d1419579 Mon Sep 17 00:00:00 2001
From: "Swapnil Kulkarni (coolsvap)" <me@coolsvap.net>
Date: Thu, 7 Jan 2016 12:40:09 +0530
Subject: [PATCH] Use assertTrue/False instead of assertEqual(T/F)
The usage of assertEqual(True/False, ***) should be changed
to a meaningful format of assertTrue/False(***).
Change-Id: I3437634329fc8ecef25082b43b5fc0e1030cdbda
Closes-Bug:#1512207
---
openstackclient/tests/common/test_logs.py | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/openstackclient/tests/common/test_logs.py b/openstackclient/tests/common/test_logs.py
index fe054a3ba7..a319533ace 100644
--- a/openstackclient/tests/common/test_logs.py
+++ b/openstackclient/tests/common/test_logs.py
@@ -137,7 +137,7 @@ class TestLogConfigurator(utils.TestCase):
self.cliff_log.setLevel.assert_called_with(logging.ERROR)
self.stevedore_log.setLevel.assert_called_with(logging.ERROR)
self.iso8601_log.setLevel.assert_called_with(logging.ERROR)
- self.assertEqual(False, configurator.dump_trace)
+ self.assertFalse(configurator.dump_trace)
@mock.patch('logging.getLogger')
@mock.patch('openstackclient.common.logs.set_warning_filter')
@@ -149,7 +149,7 @@ class TestLogConfigurator(utils.TestCase):
warning_filter.assert_called_with(logging.DEBUG)
self.requests_log.setLevel.assert_called_with(logging.DEBUG)
- self.assertEqual(True, configurator.dump_trace)
+ self.assertTrue(configurator.dump_trace)
@mock.patch('logging.FileHandler')
@mock.patch('logging.getLogger')
@@ -199,4 +199,4 @@ class TestLogConfigurator(utils.TestCase):
self.root_logger.addHandler.assert_called_with(file_logger)
file_logger.setFormatter.assert_called_with(mock_formatter)
file_logger.setLevel.assert_called_with(logging.INFO)
- self.assertEqual(False, configurator.dump_trace)
+ self.assertFalse(configurator.dump_trace)