openstack/python-openstackclient
Code Issues Proposed changes

Fix format errors in nova security group rule list

Browse Source 
* port range was throwing exception for None to/from ports
* ip_range didn't always have cidr causing error
* ip_protocol None at times and looked bad

Closes-Bug #1256935

Change-Id: I451a0f038a3e9646bca3f278c5d6f6d7e3097a83
This commit is contained in:
Terry Howe 2014-02-20 09:29:38 -07:00 committed by Gerrit Code Review
parent 2958421755
commit ada9d35cbe
1 changed files with 15 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
openstackclient/compute/v2/security_group.py
View File

@ -31,15 +31,23 @@ from openstackclient.common import utils
def _xform_security_group_rule(sgroup): def _xform_security_group_rule(sgroup):
info = {} info = {}
info.update(sgroup) info.update(sgroup)
info.update( from_port = info.pop('from_port')
{'port_range': "%u:%u" % ( to_port = info.pop('to_port')
info.pop('from_port'), if isinstance(from_port, int) and isinstance(to_port, int):
info.pop('to_port'), port_range = {'port_range': "%u:%u" % (from_port, to_port)}
)} elif from_port is None and to_port is None:
) port_range = {'port_range': ""}
info['ip_range'] = info['ip_range']['cidr'] else:
port_range = {'port_range': "%s:%s" % (from_port, to_port)}
info.update(port_range)
if 'cidr' in info['ip_range']:
info['ip_range'] = info['ip_range']['cidr']
else:
info['ip_range'] = ''
if info['ip_protocol'] == 'icmp': if info['ip_protocol'] == 'icmp':
info['port_range'] = '' info['port_range'] = ''
elif info['ip_protocol'] is None:
info['ip_protocol'] = ''
return info return info