openstack/python-openstackclient
Code Issues Proposed changes

Merge "network: Make 'network qos rule create --type' option required"

Browse Source
This commit is contained in:
Zuul
2021-03-20 05:54:26 +00:00
committed by Gerrit Code Review
parent 7c6b689fdd c58f0277a7
commit b527ec15a9
1 changed files with 1 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
openstackclient/network/v2/network_qos_rule.py
View File

@@ -84,9 +84,6 @@ def _get_attrs(network_client, parsed_args, is_create=False):
{'rule_id': parsed_args.id}) {'rule_id': parsed_args.id})
raise exceptions.CommandError(msg) raise exceptions.CommandError(msg)
else: else:
if not parsed_args.type:
msg = _('"Create" rule command requires argument "type"')
raise exceptions.CommandError(msg)
rule_type = parsed_args.type rule_type = parsed_args.type
if parsed_args.max_kbps is not None: if parsed_args.max_kbps is not None:
attrs['max_kbps'] = parsed_args.max_kbps attrs['max_kbps'] = parsed_args.max_kbps
@@ -188,6 +185,7 @@ class CreateNetworkQosRule(command.ShowOne):
parser.add_argument( parser.add_argument(
'--type', '--type',
metavar='<type>', metavar='<type>',
required=True,
choices=[RULE_TYPE_MINIMUM_BANDWIDTH, choices=[RULE_TYPE_MINIMUM_BANDWIDTH,
RULE_TYPE_DSCP_MARKING, RULE_TYPE_DSCP_MARKING,
RULE_TYPE_BANDWIDTH_LIMIT], RULE_TYPE_BANDWIDTH_LIMIT],