openstack/python-openstackclient
Code Issues Proposed changes

Fix functional-tips job

Browse Source 
A recent change to cliff [1] means we're now stripping periods when
generating the summary line of command help strings. Account for this.

[1] https://review.opendev.org/c/openstack/cliff/+/867274

Change-Id: I45b39b9fe38914497505f157e91d84cd2f84f547
Signed-off-by: Stephen Finucane <sfinucan@redhat.com>
This commit is contained in:
Stephen Finucane 2022-12-14 10:39:44 +00:00
parent 29129a7715
commit b52ae93cd2
2 changed files with 8 additions and 9 deletions
openstackclient
compute/v2
server.py
tests/functional/common
test_help.py

9
openstackclient/compute/v2/server.py

@ -2748,8 +2748,9 @@ class ListServer(command.Lister):
class LockServer(command.Command):
_description = _("Lock server(s). A non-admin user will not be able to "
"execute actions")
_description = _("""Lock server(s)
A non-admin user will not be able to execute actions.""")
def get_parser(self, prog_name):
parser = super(LockServer, self).get_parser(prog_name)
@ -4516,7 +4517,7 @@ class SshServer(command.Command):
class StartServer(command.Command):
_description = _("Start server(s).")
_description = _("Start server(s)")
def get_parser(self, prog_name):
parser = super(StartServer, self).get_parser(prog_name)
@ -4548,7 +4549,7 @@ class StartServer(command.Command):
class StopServer(command.Command):
_description = _("Stop server(s).")
_description = _("Stop server(s)")
def get_parser(self, prog_name):
parser = super(StopServer, self).get_parser(prog_name)

8
openstackclient/tests/functional/common/test_help.py

@ -30,9 +30,7 @@ class HelpTests(base.TestCase):
('server image create',
'Create a new server disk image from an existing server'),
('server list', 'List servers'),
('server lock',
'Lock server(s). '
'A non-admin user will not be able to execute actions'),
('server lock', 'Lock server(s)'),
('server migrate', 'Migrate server to different host'),
('server pause', 'Pause server(s)'),
('server reboot', 'Perform a hard or soft server reboot'),
@ -46,8 +44,8 @@ class HelpTests(base.TestCase):
('server shelve', 'Shelve and optionally offload server(s)'),
('server show', 'Show server details'),
('server ssh', 'SSH to server'),
('server start', 'Start server(s).'),
('server stop', 'Stop server(s).'),
('server start', 'Start server(s)'),
('server stop', 'Stop server(s)'),
('server suspend', 'Suspend server(s)'),
('server unlock', 'Unlock server(s)'),
('server unpause', 'Unpause server(s)'),