openstack/python-openstackclient
Code Issues Proposed changes

Workaround for failing tests on openstacksdk change

Browse Source 
The 'show-instance-action-finish-time' blueprint [1] adds support for
showing 'finish_time' for InstanceAction object.

This change adds 'finish_time' as hidden column, so it doesn't fail
tests.

We need to remove this from hidden_column list, once all the changes
related to blueprint are merged and show the field only if microversion
is >= 2.101

This is a workaround for failing tests on patch [2], as per suggestion
from Stephen.

[1] https://blueprints.launchpad.net/openstack/?searchtext=show-instance-action-finish-time
[2] https://review.opendev.org/c/openstack/openstacksdk/+/930562

Implements: blueprint show-instance-action-finish-time
Change-Id: Ib9294a603daed0fdb936be128dfba254b9108799
This commit is contained in:
Rajesh Tailor 2025-04-09 12:02:58 +05:30
parent 7ecdb69f08
commit c66abfc76f
1 changed files with 1 additions and 1 deletions

2
openstackclient/compute/v2/server_event.py

@ -82,7 +82,7 @@ class ServerActionEventColumn(columns.FormattableColumn):
def _get_server_event_columns(item, client):
hidden_columns = ['name', 'server_id', 'links', 'location']
hidden_columns = ['name', 'server_id', 'links', 'location', 'finish_time']
if not sdk_utils.supports_microversion(client, '2.58'):
# updated_at was introduced in 2.58