From 9c95b378323fdc37d403c3757064349c9aaa509b Mon Sep 17 00:00:00 2001 From: jiaxi Date: Sun, 19 Jul 2015 02:39:06 -0400 Subject: [PATCH] --property should be required in `os unset` commands The three commands below openstack volume unset openstack snapshot unset openstack volume type unset Should have --property as a required argument, not optional. The reason is the command will not work without --property. Closes-Bug: #1475872 Change-Id: Ib9e29392472db38982cc2817af2dd5055f5a01ca --- openstackclient/volume/v1/snapshot.py | 1 + openstackclient/volume/v1/type.py | 1 + openstackclient/volume/v1/volume.py | 1 + 3 files changed, 3 insertions(+) diff --git a/openstackclient/volume/v1/snapshot.py b/openstackclient/volume/v1/snapshot.py index 5ec2b3c5ca..e81efb5aaf 100644 --- a/openstackclient/volume/v1/snapshot.py +++ b/openstackclient/volume/v1/snapshot.py @@ -263,6 +263,7 @@ class UnsetSnapshot(command.Command): default=[], help='Property to remove from snapshot ' '(repeat to remove multiple values)', + required=True, ) return parser diff --git a/openstackclient/volume/v1/type.py b/openstackclient/volume/v1/type.py index 46d1828b1e..fced73b9c5 100644 --- a/openstackclient/volume/v1/type.py +++ b/openstackclient/volume/v1/type.py @@ -166,6 +166,7 @@ class UnsetVolumeType(command.Command): default=[], help='Property to remove from volume type ' '(repeat option to remove multiple properties)', + required=True, ) return parser diff --git a/openstackclient/volume/v1/volume.py b/openstackclient/volume/v1/volume.py index ad9671e35f..884611eccb 100644 --- a/openstackclient/volume/v1/volume.py +++ b/openstackclient/volume/v1/volume.py @@ -437,6 +437,7 @@ class UnsetVolume(command.Command): default=[], help='Property to remove from volume ' '(repeat option to remove multiple properties)', + required=True, ) return parser