openstack/python-openstackclient
Code Issues Proposed changes

Add new hacking rules

Browse Source 
To catch some obvious issues.

Change-Id: Ic0ddc95100811e7b313b519aad7d687a1415020b
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
This commit is contained in:
Stephen Finucane
2025-11-07 12:41:29 +00:00
parent 7116449190
commit eb7c4c61a9
5 changed files with 127 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
openstackclient/tests/unit/network/test_common.py
View File

@@ -126,12 +126,12 @@ class TestNetworkAndCompute(utils.TestCommand):
# Create client mocks. Note that we intentionally do not use specced
# mocks since we want to test fake methods.
self.app.client_manager.network = mock.Mock()
self.network_client = self.app.client_manager.network
self.app.client_manager.network = mock.Mock() # noqa: O401
self.network_client = self.app.client_manager.network # noqa: O401
self.network_client.network_action.return_value = 'take_action_network'
self.app.client_manager.compute = mock.Mock()
self.compute_client = self.app.client_manager.compute
self.app.client_manager.compute = mock.Mock() # noqa: O401
self.compute_client = self.app.client_manager.compute # noqa: O401
self.compute_client.compute_action.return_value = 'take_action_compute'
self.cmd = FakeNetworkAndComputeCommand(self.app, None)
@@ -201,9 +201,9 @@ class TestNeutronCommandWithExtraArgs(utils.TestCommand):
# Create client mocks. Note that we intentionally do not use specced
# mocks since we want to test fake methods.
self.app.client_manager.network = mock.Mock()
self.network_client = self.app.client_manager.network
self.network_client.test_create_action = mock.Mock()
self.app.client_manager.network = mock.Mock() # noqa: O401
self.network_client = self.app.client_manager.network # noqa: O401
self.network_client.test_create_action = mock.Mock() # noqa: O402
# Subclasses can override the command object to test.
self.cmd = FakeCreateNeutronCommandWithExtraArgs(self.app, None)