openstack/python-openstackclient
Code Issues Proposed changes

Replace assertItemsEqual with assertCountEqual

Browse Source 
Follow-up of [1]. After this patch was sent, two more assertItemsEqual
were added in [2]. This patch is fixing it.

[1] https://review.opendev.org/c/openstack/python-openstackclient/+/789410
[2] https://review.opendev.org/c/openstack/python-openstackclient/+/781637

Change-Id: Ic2276bd0ff0f5df76505f37d8994b3384d40e9a7
This commit is contained in:
Alfredo Moralejo
2021-09-09 15:49:04 +02:00
parent 3a0571c4df
commit ed5d2a37c5
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
openstackclient/tests/unit/volume/v3/test_volume_message.py
View File

@@ -198,7 +198,7 @@ class TestVolumeMessageList(TestVolumeMessage):
limit=None, limit=None,
) )
self.assertEqual(self.columns, columns) self.assertEqual(self.columns, columns)
self.assertItemsEqual(self.data, list(data)) self.assertCountEqual(self.data, list(data))
def test_message_list_with_options(self): def test_message_list_with_options(self):
self.app.client_manager.volume.api_version = \ self.app.client_manager.volume.api_version = \
@@ -227,7 +227,7 @@ class TestVolumeMessageList(TestVolumeMessage):
limit=3, limit=3,
) )
self.assertEqual(self.columns, columns) self.assertEqual(self.columns, columns)
self.assertItemsEqual(self.data, list(data)) self.assertCountEqual(self.data, list(data))
def test_message_list_pre_v33(self): def test_message_list_pre_v33(self):
self.app.client_manager.volume.api_version = \ self.app.client_manager.volume.api_version = \