openstack/python-openstackclient
Code Issues Proposed changes

Followup: Reduce LOC in volume v3 service

Browse Source 
This is a followup of[1] in which we are reducing LOC by removing
redundant definition of columns.

[1] https://review.opendev.org/c/openstack/python-openstackclient/+/922865

Change-Id: I2992d3ab678e751726906926b680e4aa9ad1d502
This commit is contained in:
Rajat Dhasmana
2024-06-28 20:30:56 +05:30
parent ca81b1acf0
commit f52e888dab
1 changed files with 10 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

29
openstackclient/volume/v3/service.py
View File

@@ -25,30 +25,21 @@ class ListService(service_v2.ListService):
def take_action(self, parsed_args): def take_action(self, parsed_args):
service_client = self.app.client_manager.volume service_client = self.app.client_manager.volume
if parsed_args.long: columns = [
columns = [ "Binary",
"Binary", "Host",
"Host", "Zone",
"Zone", "Status",
"Status", "State",
"State", "Updated At",
"Updated At", ]
"Disabled Reason",
]
else:
columns = [
"Binary",
"Host",
"Zone",
"Status",
"State",
"Updated At",
]
if service_client.api_version >= api_versions.APIVersion('3.7'): if service_client.api_version >= api_versions.APIVersion('3.7'):
columns.append("Cluster") columns.append("Cluster")
if service_client.api_version >= api_versions.APIVersion('3.49'): if service_client.api_version >= api_versions.APIVersion('3.49'):
columns.append("Backend State") columns.append("Backend State")
if parsed_args.long:
columns.append("Disabled Reason")
data = service_client.services.list( data = service_client.services.list(
parsed_args.host, parsed_args.service parsed_args.host, parsed_args.service