openstack/python-openstackclient
Code Issues Proposed changes

Replace assertEqual(None, *) with assertIsNone in tests

Browse Source 
In python-openstackclient some test cases using asserEqual(None, *)
instead of assertIsNone(). assertIsNone method provides clear error message.

Change-Id: I3069a6436d11efa513ae94f21ceab46c498d6e25
Closes-Bug: #1527054
This commit is contained in:
SaiKiran
2015-12-17 16:37:00 +05:30
parent 251939fb36
commit fe7d2d12c0
3 changed files with 8 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
openstackclient/tests/identity/v3/test_identity_provider.py
View File

@@ -638,5 +638,5 @@ class TestIdentityProviderSet(TestIdentityProvider):
# expect take_action() to return (None, None) as
# neither --enable nor --disable was specified
self.assertEqual(None, columns)
self.assertEqual(None, data)
self.assertIsNone(columns)
self.assertIsNone(data)

6
openstackclient/tests/network/v2/test_network.py
View File

@@ -301,7 +301,7 @@ class TestDeleteNetwork(TestNetwork):
result = self.cmd.take_action(parsed_args)
self.network.delete_network.assert_called_with(self._network)
self.assertEqual(None, result)
self.assertIsNone(result)
class TestListNetwork(TestNetwork):
@@ -443,7 +443,7 @@ class TestSetNetwork(TestNetwork):
result = self.cmd.take_action(parsed_args)
self.network.update_network.assert_called_with(self._network)
self.assertEqual(None, result)
self.assertIsNone(result)
def test_set_that(self):
self._network.is_dirty = True
@@ -463,7 +463,7 @@ class TestSetNetwork(TestNetwork):
result = self.cmd.take_action(parsed_args)
self.network.update_network.assert_called_with(self._network)
self.assertEqual(None, result)
self.assertIsNone(result)
def test_set_nothing(self):
self._network.is_dirty = False

6
openstackclient/tests/network/v2/test_router.py
View File

@@ -115,7 +115,7 @@ class TestDeleteRouter(TestRouter):
result = self.cmd.take_action(parsed_args)
self.network.delete_router.assert_called_with(self._router)
self.assertEqual(None, result)
self.assertIsNone(result)
class TestListRouter(TestRouter):
@@ -235,7 +235,7 @@ class TestSetRouter(TestRouter):
'name': 'noob',
}
self.network.update_router.assert_called_with(self._router, **attrs)
self.assertEqual(None, result)
self.assertIsNone(result)
def test_set_that(self):
arglist = [
@@ -257,7 +257,7 @@ class TestSetRouter(TestRouter):
'distributed': False,
}
self.network.update_router.assert_called_with(self._router, **attrs)
self.assertEqual(None, result)
self.assertIsNone(result)
def test_set_distributed_centralized(self):
arglist = [