Commit Graph

91 Commits (30d5f14a700dd53d80e0fbedefd9b1ad337390f9)

Author SHA1 Message Date
Elod Illes 5b04a86d1f Replace deprecated UPPER_CONSTRAINTS_FILE variable
the new environment variable name that replaces it [1].


Change-Id: Ic0d2dcf20f7929733deb10a275e5d67f9627428f
3 years ago
Zuul 7046562919 Merge "bump py37 to py38 in tox.ini" 3 years ago
maaoyu 4b709a2c04 Remove install unnecessary packages
The docs requirements migrated to doc/requirements.txt
we need not install things from requirements.txt.

Change-Id: I35a367505b2b423c345b05519e4134113cb66648
3 years ago
wangzihao cbc1fb08ec bump py37 to py38 in tox.ini
in 'victoria' cycle, we should test py38 by default.
and remove redundant python env.

Change-Id: I6426cc55ee9b6bee96620a8185fbdb39c24a68a8
3 years ago
Monty Taylor 7696593dc1 Remove os-client-config references
We've depended on openstacksdk for config for ages now, clean up
after ourselves and stop installing it in tests.

Change-Id: I66b3ec2a36bc462d2f1ac151e95ccbdc946076b8
3 years ago
Daniel Bengtsson bf2beb9e86 Stop configuring install_command in tox and stop use pip.
Currently, we are overriding 'install_command' to use 'pip'. This is
considered poor behavior and 'python -m pip' should be used instead:

It turns out that this is the the default value provided by tox:

So we can remove the line and simply use the default value. Use the
right way when it's necessary.

Change-Id: I410173d5fdcd8c592d98eed2f48b98e06299e8b3
3 years ago
Monty Taylor 32080f7a42 Bump tox minversion
ignore_basepython_conflict was introduced in tox 3.1.0.

Change-Id: I7a6049b6a4fd3ee376a3478e94837c0afe89d4df
3 years ago
Daniel Bengtsson 924627678d Stop testing python 2 in tox and zuul.
Remove python 2 from envlist parameter. Check the link:

The plan is drop the python 2 support from OpenStack in Ussuri release.
Remove the zuul jobs.

Note that the (non-voting) openstackclient-check-plugins job is still
running under py2 at this time. That will need to be fixed in the
python/openstackclient repository where the job is defined.

Change-Id: I3148db053b9ef0fcf7dc88e5cc075d974c93d819
4 years ago
Eric Fried 6f07828bf0 Add redirect testing
Adds a dependency on and invocation of the `whereto` command to validate
redirects in the .htaccess file during doc builds.

Change-Id: Ib6cc2953f0fd774de3c3a0c8a2bd6cff49667c14
4 years ago
Stephen Finucane 6419533f43 Bump hacking version
Pick up newer versions of this library. Thankfully no serious changes
are needed.

Change-Id: I69e523844529fc1c8aa0c1ce764182dbe29cfeb6
Signed-off-by: Stephen Finucane <>
4 years ago
Corey Bryant b41d7518c3 Add Python 3 Train unit tests
This is a mechanically generated patch to ensure unit testing is in place
for all of the Tested Runtimes for Train.

See the Train python3-updates goal document for details:

Change-Id: I7d0a996b33d4d1eec436f92fbd390968cd37630c
Story: #2005924
Task: #34232
4 years ago
Zuul d270174a21 Merge "Add Python 3 Train unit tests" 4 years ago
pengyuesheng d16d98b27b Update the constraints url
For more detail, see

Change-Id: Ie0a41fa97696bcd8b5fd2e670efdf9379ff1080e
4 years ago
pengyuesheng 5986f47306 Add Python 3 Train unit tests
See the Train python3-updates goal document for details:

Change-Id: I897645a4cb9f03ca464daa14f0895572212b81d9
4 years ago
Ghanshyam Mann a8309a2a85 Dropping the py35 testing
All the integration testing has been moved to
Bionic now[1] and py3.5 is not tested runtime for
Train or stable/stein[2].

As per below ML thread, we are good to drop the py35
testing now:


Change-Id: Ie7bcc327fd588a1ff6b2556d49017df56bc55bf8
4 years ago
Dean Troyer 0f56b7d074 Followup opendev cleanup and test jobs
* upper-constraints references need s/plain/raw/

Change-Id: I04368dc42f1a62a048ac9d11497747ef6f600515
Signed-off-by: Dean Troyer <>
4 years ago
whoami-rajat 0a187905c0 Add py36 env
While running `tox` command in binoic env, we see the following
ERROR: InterpreterNotFound: python3.5
It is because the default py3 version for binoic is py36.
This patch adds the env in OSC also maintaining consistency
with setup.cfg

Change-Id: I8e5cf72901cba34ad44f2b356609f85b3b0c431f
4 years ago
Monty Taylor 2dd5393167
Use os-cloud instead of OS env vars for functional tests
In order to support switching auth contexts, such as for registered_limits
which take a system scoped token, switch the functional tests to using
the --os-cloud command line parameter. However, honor the OS_CLOUD env var
as a way that someone can select a different cloud, including 'envvars',
to use.

Use devstack-system-admin cloud for limit tests

Keystone requires these to have system scope now.

Change-Id: Ia81eebd3e00ae986cf3ba7e3d98f3e8a1647b622
4 years ago
Doug Hellmann 544f0e2b3f fix tox python3 overrides
We want to default to running all tox environments under python 3, so
set the basepython value in each environment.

We do not want to specify a minor version number, because we do not
want to have to update the file every time we upgrade python.

We do not want to set the override once in testenv, because that
breaks the more specific versions used in default environments like
py35 and py36.

Change-Id: I051f1c18b719a27372b626d483e47327085dd3b7
Signed-off-by: Doug Hellmann <>
5 years ago
Stephen Finucane 63d741fd66 Replace pbr autodoc with sphinxcontrib-apidoc
This fixes local building of the documentation using tox, and allows the
gate to stop relying on pbr and move completely to the new docs PTI.

Change-Id: I485acda07098a435753e91c1ca45e586de199c35
5 years ago
Doug Hellmann bf32cdf3a9 add lower-constraints job
Create a tox environment for running the unit tests against the lower
bounds of the dependencies.

Create a lower-constraints.txt to be used to enforce the lower bounds
in those tests.

Add openstack-tox-lower-constraints job to the zuul configuration.

for more details.

Change-Id: I4a4ca9726fab1d0cf9a33311201b7f65951a0942
Signed-off-by: Doug Hellmann <>
5 years ago
Monty Taylor 6168ca7a89
Rename python-openstacksdk to openstacksdk
Change-Id: I6169f9e98418055c7c3ae5bc3b76b1216703cd55
5 years ago
Matt Riedemann 8468b2a064 Fix tox -e venv -- reno new <slug>
Change I7e8c47dead1e019e8705db3ff7559dd39b1d90d9 broke
the ability to create a new release note from the venv
tox target because the reno requirement was moved from
test-requirements.txt. This fixes it.

Change-Id: Ifac83121388728fa445e0ed4433c9d981c057737
5 years ago
Doug Hellmann 189aec9b18 Partially Revert "Update new documentation PTI jobs"
The zuul job figures out whether to run " build_sphinx" or
"build-sphinx" based on whether the project is relying on pbr's
ability to auto-generate API reference docs. Because we are relying on
that, we want local builds to use " build_sphinx".

This reverts commit 42e0037cd0.

Change-Id: Ia01188110fa9c3ccaf3d794fa3a511a6780e683e
5 years ago
Guoqiang Ding 42e0037cd0 Update new documentation PTI jobs
For compliance with the Project Testing Interface as described in [1].
For more detailed information, please refer to [2].


Change-Id: I7e8c47dead1e019e8705db3ff7559dd39b1d90d9
6 years ago
Masayuki Igawa bafe5357c2
Switch to use stestr directly
This commit makes to use stestr instead of ostestr
directly. ostestr>1.0.0 has started to use stestr instead of
testrepository. So there is no reason to use ostestr anymore.

Change-Id: I6327d50c9f6dd19f1de24b9b51532104fb3e916e
6 years ago
Dean Troyer 1d914dd9ad Fix SDK Connection creation alternative to Profile
Do a dummy import to determine which SDK is installed (Pre/post merge).

This solves the DevStack error "Cloud defaults was not found" in -tips jobs.

Depends-On: Ia111f127fbdceac2afe20fd9d1fe032145cdd72c
Change-Id: I60c2d418dd5a393eee2cc2a5c2fdebfffdabf2d3
6 years ago
Andreas Jaeger 0bf69a9462 Remove -U from pip install
'pip install -U' ugrades specified packages, this is not necessary
since we use constraints, remove the parameter '-U' from the line.

With tools/ - which a previous change of mine removed -
the -U was not harmful, but with the current set up, it might cause
upgrades, so remove it.

Change-Id: I9f818d4b78e7540498a1501be14cd63ac3e891b3
6 years ago
Monty Taylor 8b32b53a0f
Avoid for constraints support
We do not need, pip can handle constraints itself
and install the project correctly. Thus update tox.ini and remove
the now obsolete tools/ file.

This follows to remove

Change-Id: Ie7c06ead39c8597ec9326f223625d1fa0d5208d1
6 years ago
Monty Taylor b061b9c34e
Add cliff and keystoneauth to tips jobs
Both of these can severely break openstackclient. Add them to the
required-projects list of the tips jobs. We should then add at least
osc-tox-unit-tips but maybe also osc-functional-devstack-tips to both
cliff and keystoneauth so that it's symmetrical.

Change-Id: Ie0f3e9d7e221c9cdd3c5d726148f456246186ff4
6 years ago
Dean Troyer 90230c3766 Zuul job updates
* Add unit-tips job to run unit tests with the same project master branches
  as the functional-tips job (mostly useful for the unit.integ tests)
* Add irrelevant-files to the osc-functional-devstack-base job
* Comment out the functional-n-net job as it is horribly broken for now
  until the replacement package-installed OpenStack is ready

Change-Id: I5acdcb0a2f0f0dfe488740ae0add36366cc0ee21
6 years ago
Dean Troyer 676159555f Native DevStack jobs
Convert legacy DevStack jobs to native Zuul v3 form, plus some
test-job-related docs updates.

Change-Id: Ia8c08be81605da885b9eee799fc58129305dfc41
6 years ago
Monty Taylor ef595fcfc4 Add wrapper around ostestr
The functional tests assume that an openrc file has been sourced. Make a
simple wrapper that will do that.

Change-Id: I42584aaebcbca99a8c922f6ff90c8bbce57bbfbb
6 years ago
Dean Troyer 7274e8efe6 Updates for stestr
Change-Id: I860981f06e31abda3141a0cb4fd13a0d49080b50
6 years ago
Akihiro Motoki ff85c62707 flake8-import-order: Ensure to place project imports last
To ensure project imports are placed after third party import,
we need to specify application-import-names.
Previously flake8-import-check checked only standard imports or not.

Change-Id: Iad7afa456cec7cf5b44955f1ea03c593a4c0e426
6 years ago
Akihiro Motoki f3bbf52b3c Use flake8-import-order plugin
In reviews we usually check import grouping but it is boring.
By using flake8-import-order plugin, we can avoid this.
It enforces loose checking so it sounds good to use it.
This flake8 plugin is already used in tempest.

Note that flake8-import-order version is pinned to avoid unexpected
breakage of pep8 job.

Setup for unit tests of hacking rules is tweaked to disable
flake8-import-order checks. This extension assumes an actual file exists
and causes hacking rule unit tests.

Change-Id: I12b596820727aeeb379bee16c2bc993dee9eb637
6 years ago
blue55 20c23d8ccb Enable some off-by-default checks
Some of the available checks are disabled by default, like:
[H203] Use assertIs(Not)None to check for None

Change-Id: I59dafb62cedc5217b6e5eb6efb997a9ee3c29bbb
6 years ago
Rui Chen af435ee0a8 Remove ipdb installation in tox debug section
The lastest ipdb depends on ipython 6.0, but ipython 6.0
only can be installed in python 3.3 and above, see . If we try to
run "tox -e debug" in python2.7, the install error is raised
and block the function. Remove the ipdb installation, it's
not necessary, we can use pdb to replace.

Change-Id: Ib47bb5925b7a5b1d3a319b58fa219c1b57dccb93
6 years ago
yangweiwei 13bba78ca5 Update to tox.ini
When do the action "tox -e pep8", result is "ValueError: No closing
quotation". Which is caused by the tox.ini. The min tox version is
1.6. In my environment, tox version is 2.2.1. If the tox version is
more than 2.3, the error will not happen.

Depends-on:  Iee7b043ac7d381dadf89d26098f69e935ed81d6b
Change-Id: Id10ddf6244e7e25e6f66c97773d426b0b4789479
6 years ago
Eric Brown 73c2a809f7 Remove py34 tox env and pypi classifier
Currently only py27 and py35 (not py34) is tested in the gate, so
py34 should no longer be part of the tox environment or part of the
PyPi classifier.

Change-Id: I155fc0e3ac06b495718d9fa3058edded738cb011
6 years ago
Rui Chen fd0ac815de Functional tests debug support
Pass OS_* options into tox debug venv in order to
debug functional tests in local, and install ipdb
to make code-debug more convenient.

Change-Id: Ib926948f2b9a52921cf7487fe16ef716481e3ceb
6 years ago
Monty Taylor 63cdf079b1 Use git+file urls instead of directories
The /opt/stack/new directories are owned by the wrong user, so python egg_info fails because it can't create the egg_info dir.
Changing the invocation to use git+file:// urls solves the problem.

Additionally, make a correction to test collection.

Change-Id: I39da0b26417dce1a72b15dedc02d10284329307f
6 years ago
Monty Taylor 64385002ea Install from /opt/stack/new instead of git.o.o
Installing directly from the git url will bypass any depends-on
processing zuul may have done on the dependent repos.

Change-Id: I3dadacf7a855cc4efad701f0a6275d6cd60efd72
6 years ago
Steve Martinelli d98b72c245 add support for running tests with master dependencies
we can create a new infra job that points to the new test hook,
which should install the master version of the SDK, osc-lib
and os-client-config.

Change-Id: Ib6391893b2302bdc514525d5ddda886fe8c60100
6 years ago
Steve Martinelli c14d3efe61 move all functional tests to tests module
functional tests should be grouped with other tests (unit and
integration tests). as part of this commit the "common" module
was renamed to just "base", this was done for simplicity.

the file was also copied to the functional module
since it should live there. a separate change to the infra repo
will be made to call the new location, once that is merged we
can remove the old one (a new change will also be posted for that)

Needed-By: I49d54f009021d65c1ae49faf6b3f0a7acdadd7b3
Change-Id: Ie8c334f6223373b8e06df8bd8466500d2a2c8ede
7 years ago
Dean Troyer 2a1a174086 Gate-unbreaking combo review
Fix argument precedence hack
  Working around issues in os-client-config <= 1.18.0

  This is ugly because the issues in o-c-c 1.19.1 run even deeper
  than in 1.18.0, so we're going to use 1.19.0 get_one_cloud() that
  is known to work for OSC and fix o-c-c with an axe.

Remove return values for set commands
  'identity provider set' and 'service provider set' were still
  returning their show-like data, this is a fail for set commands
  now, don't know how this ever passed before...

Constraints are ready to be used for tox.ini
  Per email[1] from Andreas, we don't need to hack at install_command
  any longer.


Co-authorioed-by: Steve Martinelli <>
Depends-On: I49313dc7d4f44ec897de7a375f25b7ed864226f1
Change-Id: I426548376fc7d3cdb36501310dafd8c44d22ae30
7 years ago
Huanxuan Ao ab32f37e67 Remove an outdated directory in tox.ini
The directory openstack/common from the exclude list of
flake8 in tox.ini was used to keep codes from oslo-incubator,
but oslo-incubator was retired, so don't use this directory
any more.

Change-Id: If1ea5dc167cfe4a09aad413b9eab0af807ebe603
7 years ago
Steve Martinelli e2a9fd29c1 Follow upper constraints for all tox targets
With the exception of releasenotes and cover, we should follow
upper constraints. The tox_install file was copied over from
python-neutronclient [1].


Change-Id: I633fa149820efafd7b2acec0388fa8bc8d06c988
7 years ago
zheng yin e40e1f6990 Add Python3.5 to setup.cfg tox.ini
Now that there is a passing gate job, we can claim support for Python 3.5
in the classifier. This patch also adds the convenience py35 venv.

Change-Id: If93af96739741584c87913ba140d0c6cee2aa10d
7 years ago
Sheel Rana 095edbc367 Pep8 environment to run on delta code only
Currently tox -epep8 will run flake8 on whole code.
To make this fast, flake8 support is added for only
updated(delta) code.

Same can be run by "tox -efast8".

Change-Id: I9c55fed32ae3060c21ec278398e9e07fb4a0fe13
Implements: BP tox-pep8-diff-part-only
7 years ago