58 Commits

Author SHA1 Message Date
Jenkins
5b8f18fe4b Merge "Rename --verify for server resize to avoid conflict" 2015-03-05 20:27:32 +00:00
Dean Troyer
5d92fc0d0a Handle novaclient >2.20.0
As of 2.21.0 novaclient moved all of the v1_1 classes to v2 with a
deprecation warning.  The version-non-specific interfaces provided in
novaclient.client are insufficient to support a few specific commands in
OSC so we need to conditionally import directly from the correct classes.

Closes-Bug: #1418024
Change-Id: I864b1908737803069dc1419c9cbca391b985c932
2015-03-03 13:02:11 +00:00
zhiyuan_cai
a33f14e298 Rename --verify for server resize to avoid conflict
Currently server resize command has a verify argument for user to
confirm resize operation. But this argument is also registered by
openstack client shell which is used to enable server certificate
verification. So verify argument can not be correctly passed to
server resize command.

This patch renames --verify to --confirm (nova client has a
resize-confirm command) to solve this problem.

Change-Id: I751aa3df16c3b637b82944dd350afc5cbab62120
Closes-Bug: #1416542
2015-02-16 11:00:50 +08:00
Marcos Fermin Lobo
0cc3955f0a tenant_id to project_id in server show
The result of 'server show VM_NAME' command shows tenant_id
instead of project_id. All openstack components are moving
from 'tenant' to 'project' naming when we are talking about
openstack projects.

Change-Id: I50053b72e79e1ff3167fa573728da1a81a8e5ed8
Closes-Bug: #1417614
2015-02-04 05:43:26 +00:00
Jenkins
b131692007 Merge "Improving the help of the lock command." 2015-02-02 05:07:04 +00:00
Pedro Navarro
ee062922d1 Improving the help of the lock command.
The lock command allows you to block the actions
on the server for the non-admin users. Improving
the help so that api users understands better
what locking a server implies.

Change-Id: I925c946751602dc0f6bd1d31b514bc20bca585fa
Closes-Bug: #1366279
2015-02-01 13:15:49 -08:00
zhiyuan_cai
520b2f10cf Add 'find by name' to --nic for creating server
Add 'find by name' feature to --nic option for creating server.

Closes-Bug: #1353040
Change-Id: Idd0a30415d8360a57e33efedf2467593652683d4
2015-01-27 05:34:32 +00:00
wanghong
470b7e53a8 add multi-delete support for compute/image/net/volume
This is part1, add support for these objects:
compute.server
imagev1.image
imagev2.image
network.network
volume.volume
volume.backup
volume.snapshot

Closes-Bug: #1400597
Change-Id: Ice21fee85203a8a55417e0ead8b509b8fd6705c1
2014-12-23 09:31:10 +08:00
Dean Troyer
ac4950b46e Command object docs: server, server image
server
server image

Some cosmetic changes in the command source, sorting classes, help strings, etc.

Change-Id: I3f68dae77b9fe02bc6866684e05aeff943dd9cc3
2014-12-03 13:34:44 -06:00
Dean Troyer
2c9d263611 Fix server create for boot-from-volume
* server create required --image even when booting the server from a
  volume.  Change options to require either --image or --volume to
  specify the server boot disk.  Using --volume currently uses device
  'vda' for the block mapping and ignores any other block mappings
  given in --block-device-mapping.
* server create and server show are both affected by bug 1378842 where
  an excepion was thrown when no image ID was present in the returned
  server object, which is the case for a server booted from a volume.
* Fix the remaining assertEqual() order problems in test_server.py

Closes-Bug: 1378842
Closes-Bug: 1383338
Change-Id: I5daebf4e50a765d4920088dfead95b6295af6a4d
2014-10-24 17:55:44 -05:00
Dean Troyer
89217a6557 Close files on server create, add tests
The files opened for the --files and --user-data options were never
closed, potentially leaking memory in a long-running client. Close
them if they are file objects.

Add a couple of basic tests for server create.

Change-Id: I1658b0caa2d6af17308149cb52196ee28266ddf2
2014-10-14 15:45:20 -05:00
Steve Martinelli
111d43ad8f Update compute server messages for translation
Mark some of the messages from the server for translation

implements bp use_i18n

Change-Id: I503efcfb4ca3dec1c427b58ee4a85de9a241dacd
2014-10-08 15:05:22 -04:00
Jenkins
8cfc8529be Merge "Fix server add security group" 2014-09-06 16:09:30 +00:00
Dean Troyer
22c544a822 Fix server add security group
The group resource was being passed when only the name is needed.

Change-Id: Ia303804be4e336f9880205d931467cb831e812de
2014-08-27 17:35:30 -05:00
Jenkins
97d1bbdafd Merge "Create message variables for exceptions" 2014-08-24 20:20:08 +00:00
Steve Martinelli
c2b0cec6e3 Create message variables for exceptions
Instead of inline messages, let's create variables instead, as
it's easier to find strings, and mark them for translation.

Change-Id: Ibbcfdbc59d12a0cb4af50f73043d3ff7f3c76f99
2014-08-24 18:16:07 +00:00
Dean Troyer
ea2ac77a46 Fix server resize
So apparently we've never resized a server???

Fixed command args and add some tests.

Change-Id: I6c3f6fec22390e9d269b7117a42a190d2b4b80ba
2014-07-08 11:20:13 -05:00
Dean Troyer
11f3654f6e Fix PEP8 E265 errors
Change-Id: Ieb9a9af1da27d3935d1a4d3cfb61b0ccb03d099a
2014-06-27 09:12:55 -05:00
Jenkins
3b925e9806 Merge "replace string format arguments with function parameters" 2014-06-10 02:27:54 +00:00
Christian Berendt
3b485de6b0 replace string format arguments with function parameters
There are files containing string format arguments inside
logging messages. Using logging function parameters should
be preferred.

Change-Id: Ic749ac9eb55564ed631d57055a5a4dfc3aebd169
2014-05-20 13:49:56 +02:00
Dean Troyer
da5e31dbb6 Fix server image create
The final find_resource() call errored because servers.create_image()
returns an image ID rather than an Image resource.  Reset expectations
and arguments.

Change-Id: I1b9132f66091f9df76198724156acb7a6fb2f6fe
2014-05-08 15:04:22 -05:00
Andreas Jaeger
5043293156 Fix some help strings
This fixes some errors and inconsistencies I found reviewing the
help strings:
* Capitalize help strings
* Add missing space between words (in multi-line strings)
* Improve wording

Change-Id: I2fb31ab4191c330146e31c1a9651115a6657769a
2014-02-21 19:40:41 +01:00
Dean Troyer
200ed62054 Add server image create command
Translation of 'nova image-create', with tests!

Change-Id: I8a833aeff6f291e4774063ed235876eb2ba9c13c
2013-11-18 23:40:11 -06:00
Jenkins
f293027815 Merge "Remove tenant round 3 - other commands" 2013-07-31 22:30:12 +00:00
Jenkins
661da45f58 Merge "Add security group commands" 2013-07-31 15:16:48 +00:00
Dean Troyer
7d138b94ec Remove tenant round 3 - other commands
Mostly options and help strings:
* image, server, project usage, volume

Change-Id: I788b0660f8c2daacde53c20a72dd1afc60cf5159
2013-07-31 10:12:20 -05:00
Jenkins
9ec1cf385e Merge "Begin Python 3 compatability" 2013-07-31 15:05:01 +00:00
Dean Troyer
978c2e7dec Add server ssh command
Change-Id: I9317ad6a47818d5479a046b4be8c5adbbce613ef
2013-07-29 19:18:00 -05:00
Dean Troyer
dfb0e3e3c1 Begin Python 3 compatability
* use six.iteritems()
* replace basestring with six.string_types
* convert print statements to functions (they're all debugging and should
  be removed eventually anyway)

* clean up OpenStack copyright: LLC -> Foundation

Change-Id: Icb14212bcb408e63816bfec3922a697bc1a6c946
2013-07-29 19:12:29 -05:00
Dean Troyer
c94e262df8 Add security group commands
* Add security group: create, delete, list, set, show
* Add server: add secgroup, remove secgroup
* Add security group rule: create, delete, list
* Add Oslo's strutils and gettextutils

* Adds parseractions.RangeAction() to handle option arguments of either a single number
  or a range of numbers: '--port 25'  or '--port 1024:65535'

Blueprint: nova-client

Change-Id: Iad2de1b273ba29197709fc4c6a1036b4ae99725f
2013-07-29 19:07:22 -05:00
Dean Troyer
65d2a14e3e Add server resize command
* add server resize
* update --wait handling for server create, reboot, rebuild
* move _wait_for_status to utils

Blueprint: nova-client

Rebased after https://review.openstack.org/38162 was committed

Change-Id: I7a43b996feecadc7628fcfe20cd5b17333762739
2013-07-29 18:57:02 -05:00
Dean Troyer
3cc313a60d Add server migrate command
Blueprint: nova-client

Note: I've tested that the API calls are made correctly but do not have an
environment with migration proerly enabled to watch it complete...

Change-Id: Ideaf0985d43aa2be22390cf0d2850124c549632d
2013-07-29 18:43:16 -05:00
Dean Troyer
3ff6378c23 Add server commands: (un)lock, (un)rescue, (un)set, add/remove volume
* server lock/unlock, rescue/unrescue, set/unset
* add/remove volume

Blueprint: nova-client

Change-Id: I3709ecdb297ab15ad44df09d89af840164271a66
2013-07-29 18:21:21 -05:00
Jenkins
ec9b907e78 Merge "Fix --password in server rebuild" 2013-07-26 18:12:33 +00:00
Steve Martinelli
3789cdfebe Add server diagnose for compute api
Add server diagnose for compute api as per blueprint: nova-client

Change-Id: I0a2c13e36e1e13f61ef4ba00ec146634f9644648
2013-07-23 23:06:29 -05:00
Dean Troyer
61beeb7e20 Fix --password in server rebuild
Use correct attribute to get password in server rebuild command.

Fixes bug 1190722

Change-Id: Ibe2ccb8840a385319781885b8aadca6e1ba4cc43
2013-07-22 10:23:58 -05:00
Dean Troyer
818c948752 Clean up properties (metadata) formatting
* Reformat default dict output to key='value' using utils.format_dict()
* Changes utils.get_item_properties() to pass the specific field to
  the formatter function rather than the entire resource object, this
  allows the formatter to handle multiple attributes.
* Updates server, volume, volume type commands

Change-Id: I90eebf6b84ae200532f09cd925f371598ea54a64
2013-07-21 13:59:11 -05:00
Steve Martinelli
1a0d5ccc68 Remove api = apiName calls from each method
As discussed in https://review.openstack.org/#/c/36352/ for each
command, we were setting api = identity or volume... etc,
this was for an old way of calling commands that are is no longer
used.

Also removed openstackclient/common/command.py

Change-Id: I2705f35d343f2ae729dc22d6aed0b852b2f8ca19
2013-07-12 11:07:33 -05:00
Monty Taylor
108f78d989 Remove python3 incompatible exception syntax.
Change-Id: I5f0687a83362ceebf03bae4a0a5b109aad7e5200
2013-06-30 23:30:54 -04:00
Monty Taylor
016a0b301e Fix flake8 errors in anticipation of flake8 patch.
Change-Id: Ifdc4322b699f2bd91a6900e55695acd3d736568e
2013-05-14 08:28:48 -07:00
Josh Kearney
a2e3a16221 Rename all instances of 'metadata' to 'property'.
Change-Id: I454cbe685dc5afa0a09ecc976a90d6eb6bc57d14
2013-05-07 11:18:38 -05:00
Dean Troyer
3641b03690 metadata is one word
Change-Id: I2baff95c9b6dcc95edf5d5da74814ff37883cd2b
2013-04-08 17:23:50 -05:00
Dean Troyer
3b765c8253 Clean up args and help strings in server commands
Help string corrections and align args with wiki at
https://wiki.openstack.org/wiki/UnifiedCLI/Mapping#server

Change-Id: Ifd6f587d383534142003277e64532f77ecb37106
2013-03-06 14:40:32 -06:00
Josh Kearney
b26cb5bf68 Upgraded to PEP8 1.3.3 to stay aligned with Nova, etc.
Made all the necessary changes to pass new PEP8 standards.

Also cleaned up docstrings to conform to the HACKING stanards.

Change-Id: Ib8df3030da7a7885655689ab5da0717748c9edbe
2013-01-31 13:31:41 -06:00
Josh Kearney
0a4912f9fb Standardize on a copyright header and ensure all files have them.
Change-Id: I64812bca01ca655c9cf9239a0daea84907082a29
2013-01-24 12:02:23 -06:00
Josh Kearney
c1ea298904 Clean up test environment and remove unused imports.
First round of adding more complete unit test coverage.

Change-Id: Ic1979c499ca6fcb784892a95954a3527539c4e53
2013-01-22 11:44:18 -06:00
Dean Troyer
90a1c65f3a Update compute client bits
* add server create, delete, pause, reboot, rebuild
  resume, suspend, unpause commands

Change-Id: I728ec199e4562bd621c3a73106c90d8b790b459a
2012-09-05 16:06:49 -05:00
Dean Troyer
697a5ac6cb Refactor cliff.Command.run()
* All commands now perform their action in take_action().  Those producing
  output are derived from DisplayCommandBase.

Change-Id: Ic93ba9a2ad449d84242b6aa8624b41379c4fb79a
2012-06-20 10:03:01 -05:00
Dean Troyer
90f9f1dfa0 Clean up tenant and server
* remove '_' from class names
* add class name to log instances
* some cleanups to HACKING

Change-Id: I1f6334318ee0d7d83cd3cea0e71ba4f05dd2b5c5
2012-05-16 11:44:18 -05:00
Dean Troyer
f485d71222 Revise command boolean flags
* use --enable|--disable form for boolean 'enabled' value
* clean up logging strings

Change-Id: Ib4016bbef1763c27ec5a9edf36b926dc0d0b265c
2012-05-11 17:27:03 -05:00