openstack/python-openstackclient
Code Issues Proposed changes
2,174 Commits 7 Branches 65 Tags
9e42daa577
Commit Graph

23 Commits

Author SHA1 Message Date
Tang Chen
fc24f37ae2 Trivial: Remove useless return 
If a function returns nothing, do not add return in the end.

Change-Id: I298b8717462f68d3076a1619d674775be2a94c42
 2016-03-07 17:54:06 +08:00
Akihiro Motoki
258c1102cc log take_action parameters in a single place 
Previously each command logs take_action parameters explicitly
by using @utils.log_method decorator or log.debug().
Some commands have no logging.

This commit calls a logger in the base class and
drops all logging definition from individual commands.

Closes-Bug: #1532294
Change-Id: I43cd0290a4353c68c075bade9571c940733da1be
 2016-02-02 09:58:32 +09:00
Dean Troyer
bf090c69c2 Switch to ksa Session 
* Change session imports to keystoneauth1
* Change keystoneclient.exception imports to keystoneauth1
* Change exceptions raised from internal API from keystoneclient to openstack.common

Change-Id: I046d89f561d6fe04baae53726f9749d2e7fe2056
 2015-12-02 01:55:14 +00:00
Joshua Harlow
e3c46ece4a Use a common decorator to log 'take_action' activation 
Instead of duplicating the same log statement throughout
the code, the same logic can be provided by a shared decorator
that abstracts away the logging capability and unifies it behind
a common function instead.

Change-Id: Icc63bced7347c8bbf0299a4c5821425a10892a79
 2015-09-01 16:49:54 -07:00
Jenkins
4a8a2fb27d Merge "Rework role list v2 for --user and --project" 2015-01-13 22:35:21 +00:00
Steve Martinelli
019c155e9b Fine tune some of the helps commands 
try and add some consistency with the show and delete commands.

replace 'show x' with 'display x'
change 'delete a y' with just 'delete y'

Change-Id: I47dfa8ee23ac5c41b355796415eb515155832f65
 2015-01-13 00:58:57 -05:00
Steve Martinelli
ffb7832159 Rework role list v2 for --user and --project 
`os user role list` does the same as v3's `os role list`.
We should rework v2's `role list` to basically call `os user role list`
under the covers.

Closes-Bug: #1409179
Change-Id: I9839f6be139d6a6a3f6bbf79957e218dd8e03fe3
 2015-01-10 01:02:33 +00:00
wanghong
d8f1cbd984 add multi-delete support for identity 
This is part2. Add support for these objects:
identity.project(v2.0)
identity.role(v2.0)
identity.user(v2.0)
identity.project(v3)
identity.role(v3)
identity.user(v3)
identity.group(v3)

Closes-Bug: #1400597
Change-Id: I270434d657cf4ddc23c3aba2c704d6ef184b0dbc
 2014-12-23 09:39:29 +08:00
Jamie Lennox
25a7c1f27f Don't import form keystoneclient.openstack.common 
The keystoneclient.openstack.common directory is where we sync files
from oslo incubator. It is not a public directory and should not be
being consumed by openstackclient.

Change-Id: I011bb95c2c824e2dbc4b822ca922ae77b8d9b955
 2014-12-17 18:17:56 +10:00
Dean Troyer
04d30c1855 Command object docs: project, role, user 
project
role
user
user role

Change-Id: I445e09a3ffb69114912ae562a9285963a636bfd1
 2014-12-01 17:36:20 -05:00
Steve Martinelli
7242113a8f Add additional support for --or-show 
Add --or-show for the following:
  * v2 roles
  * v2 projects

Change-Id: Ibbae19cda668575b9527fbd259f1298c48b8265b
 2014-11-14 16:29:57 -05:00
Steve Martinelli
bb71df9ced Mark identity v2 resources for translation 
mark v2 catalog, ec2, endpoint, project, role, service and token

Change-Id: I14a5852bfee4ca9e25130d001fdadd7778ad0996
 2014-10-09 14:16:45 -04:00
Christian Berendt
3b485de6b0 replace string format arguments with function parameters 
There are files containing string format arguments inside
logging messages. Using logging function parameters should
be preferred.

Change-Id: Ic749ac9eb55564ed631d57055a5a4dfc3aebd169
 2014-05-20 13:49:56 +02:00
Dean Troyer
8898e020fb Identity v3 tests 
* Add project, user, role and service v3 tests
* Fix issues in commands with enable/disable
* Make commands and tests more consistent between versions
* Make formatting and comments more consistent

Change-Id: Id21e7a5abd7e421a7742f937861ec46b53095fc7
 2013-09-09 14:58:28 -05:00
Dean Troyer
44c97cc099 Add Identity v2 role and service tests 
* Add current auth info (auth_ref) to ClientManager
* Fix identity.v2_0.role.ListUserRole to get default user/project
  from ClientManager.auth_ref
* Fix identity.v2_0.role.AddRole call to roles.add_user_role()

Change-Id: Ie8bf41c491d97b0292a2b86bdc9b7580989a7f97
 2013-09-04 21:37:45 +00:00
Dean Troyer
c385180df2 Remove tenant round 2 - Identity API 
Rename everything in the Identity v2 code including the file and classes.
* role, tenant, user

Change-Id: I0b99c60a24f5875120136d2f216aa3b6bce1c641
 2013-07-31 10:10:45 -05:00
Dean Troyer
dfb0e3e3c1 Begin Python 3 compatability 
* use six.iteritems()
* replace basestring with six.string_types
* convert print statements to functions (they're all debugging and should
  be removed eventually anyway)

* clean up OpenStack copyright: LLC -> Foundation

Change-Id: Icb14212bcb408e63816bfec3922a697bc1a6c946
 2013-07-29 19:12:29 -05:00
Steve Martinelli
1a0d5ccc68 Remove api = apiName calls from each method 
As discussed in https://review.openstack.org/#/c/36352/ for each
command, we were setting api = identity or volume... etc,
this was for an old way of calling commands that are is no longer
used.

Also removed openstackclient/common/command.py

Change-Id: I2705f35d343f2ae729dc22d6aed0b852b2f8ca19
 2013-07-12 11:07:33 -05:00
Josh Kearney
b26cb5bf68 Upgraded to PEP8 1.3.3 to stay aligned with Nova, etc. 
Made all the necessary changes to pass new PEP8 standards.

Also cleaned up docstrings to conform to the HACKING stanards.

Change-Id: Ib8df3030da7a7885655689ab5da0717748c9edbe
 2013-01-31 13:31:41 -06:00
Josh Kearney
0a4912f9fb Standardize on a copyright header and ensure all files have them. 
Change-Id: I64812bca01ca655c9cf9239a0daea84907082a29
 2013-01-24 12:02:23 -06:00
Dean Troyer
697a5ac6cb Refactor cliff.Command.run() 
* All commands now perform their action in take_action().  Those producing
  output are derived from DisplayCommandBase.

Change-Id: Ic93ba9a2ad449d84242b6aa8624b41379c4fb79a
 2012-06-20 10:03:01 -05:00
Matt Joyce
8d089518f0 removing print call in roles get_data 
Change-Id: I2aebf6099821212d4bd4b4b6d78b9752085168b2
 2012-05-23 12:18:53 -07:00
Dean Troyer
a4aaac78a9 Add role CRUD commands 
* add {add|create|delete|list|remove|show|user-list} role commands

Change-Id: I27129168a9f58154fcdb062a533fa926737f822f
 2012-05-18 13:57:16 -05:00