openstack/python-openstackclient
Code Issues Proposed changes
4,793 Commits 7 Branches 65 Tags
bae89b3014
Commit Graph

4 Commits

Author SHA1 Message Date
lihaijing
d15bbada73 Replace six.iteritems() with .items() 
1. As mentioned in [1], we should avoid using six.iteritems to achieve
   iterators. We can use dict.items instead, as it will return iterators
   in PY3 as well. And dict.items/keys will more readable.

2. In py2, the performance about list should be negligible,
   see the link [2].

[1] https://wiki.openstack.org/wiki/Python3
[2] http://lists.openstack.org/pipermail/openstack-dev/2015-June/066391.html

Co-Authored-By: Akihiro Motoki <amotoki@gmail.com>
Change-Id: I4b9edb326444264c0f6c4ad281acaac356a07e85
Implements: blueprint replace-iteritems-with-items
 2020-01-09 18:41:29 +09:00
Rodolfo Alonso Hernandez
885b1149c3 Avoid default mutable values in arguments 
Mutable values shouldn't be used as default values in function
arguments [1].

[1] http://docs.python-guide.org/en/latest/writing/gotchas/

Change-Id: I3c7f915f0409c77f4c430467365eb1bcfd7757b3
 2017-10-10 14:04:40 +01:00
Jens Rosenboom
3e6356a4d8 Fix handling the use_default_subnet_pool attribute 
The attribute formerly wasn't working because it is lacking support in
the SDK. The patch to add it[1] introduced a modified spelling, so we
should be matching this here.

Also make sure that the attribute is not shown when displaying subnet
objects, as it is meant to be invisible[2].

[1] I72c0be77d96f3891748cdd69c382211dc20dbf5e
[2] http://git.openstack.org/cgit/openstack/neutron/tree/neutron/extensions/default_subnetpools.py#n23

Change-Id: Ic125b818a6082d76a1114fe89e0b1fcf4c7356b0
Partial-Bug: 1668223
 2017-03-09 08:21:13 +01:00
Richard Theis
70cb628278 SDK Refactor: Prepare address scope commands 
Prepare the OSC "address scope" commands for the SDK refactor.
See [1] for details.

[1] https://etherpad.openstack.org/p/osc-network-command-sdk-support

Change-Id: I4e253e01f9b0b10452354f4e4152468090c76958
Partially-Implements: blueprint network-command-sdk-support
 2016-10-05 06:36:18 -05:00