1549 Commits

Author SHA1 Message Date
Richard Theis
d906507962 Refactor security group rule create to use SDK
Refactored the 'os security group rule create' command to use the
SDK when neutron is enabled, but continue to use the nova client
when nova network is enabled.

Added a release note for the change in security group rules output
due to Network v2.

Change-Id: I8c6c99d5272ff5d410a449f73d198d834c5cd96e
Partial-Bug: #1519512
Implements: blueprint neutron-client
2016-03-23 09:56:01 -05:00
Jenkins
4b4349ee68 Merge "Fix "server unset" document issue" 2016-03-23 13:35:49 +00:00
Tang Chen
3e0e1f8c41 Trivial: Fix typo in common/limits.py
Change-Id: I3040cc69512df50459960f96b862de55804068ac
2016-03-23 16:04:21 +08:00
Rui Chen
ee621509be Fix "server unset" document issue
Fix "--property" option describe issue in "server unset"
document, and update the help message to keep consistent.

Change-Id: I68022a187e83fad6320365400ad2a1b0c8cf9a61
2016-03-23 14:45:04 +08:00
Tang Chen
41853985bb Use assert_called_once_with() instead of assert_called_with()
If one API is only called once, we'd better use assert_called_once_with()
to check the call.

Change-Id: Id05055bb90592d218826732259ed84fc366734ce
2016-03-22 10:08:51 +08:00
Jenkins
a48de855d0 Merge "Improve error for token issue command without auth" 2016-03-21 21:20:48 +00:00
Nicolas Simonds
1d1c7a0631 Image API v2: make volume_type optional
It is perfectly valid for a Cinder volume to have a volume_type of
"none", so don't make the Image API v2 require that one be set.

Change-Id: I1a6da8d791fa0ae67cac46eec81bcbcb420729c3
Closes-Bug: #1559344
2016-03-18 16:08:30 -07:00
timothy-symanczyk
15edb2f61a Improve error for token issue command without auth
Currently when you perform the 'token issue' command with
the admin_token, the error is a nonsense python error. This
commit changes it to be user-friendly.

Change-Id: I5cc92c342e3f83e099354cd04301c7b8d8d2dabc
Closes-Bug: #1547721
2016-03-18 15:44:02 -07:00
Dean Troyer
21e414d860 Fix keypair create --public-key
Commit Id702ccaad239b916340bb17014d1ede0a28aaec9 changed the keypair
create --public-key to use io.open but incorrectly reads the file
in binary mode, which causes JSON serialization to fail.

The unit tests mock out io.ioen (the reason for adding it in the first
place actually) so any testing for this specific problem would have to
be done in functional tests...yet to come.

Closes-bug: 1559125
Change-Id: I7a299a542d9df543bff43d3ea1e7907fc8c5f640
2016-03-18 17:48:36 +00:00
Jenkins
d42bb4f7e2 Merge "Fix options in port create/set" 2016-03-17 22:58:36 +00:00
Dean Troyer
aeef568189 Fix options in port create/set
* --device-id should have been --device
* --host-id should have been --host

Old options are deprecated and retained for compatibility since they
appear in a release.

Closes-Bug: 1558677

Change-Id: Ic733523c8d57060f2cb5d420fdb1f7598e7d5e71
2016-03-17 21:00:26 +00:00
Jenkins
a60e31ad4b Merge "Add option to allow filtering by router on port list" 2016-03-17 06:05:34 +00:00
Jenkins
bc5b0846f8 Merge "[compute] Add set host command" 2016-03-17 03:06:12 +00:00
Jas
62a02466c3 Add option to allow filtering by router on port list
Added support to allow filtering ports via --router
option to list ports that are applicable to specific router.

Partial-bug: #1519909
Partially-implements: blueprint neutron-client

Change-Id: I6dd958603909f641735c821a62fc0d45afd5c7ec
2016-03-16 13:20:40 -05:00
root
9bafea555d Add support for deleting Image-property
OSC does not support to delete volume's image property.
This patch will provide support for deleting image property
to existing volume.

Closes-Bug:#1554879
Change-Id: I9256913948fae9e9a03fed173b826dfa918f78e9
Implements: bp cinder-command-support
2016-03-16 10:22:00 -04:00
root
4d5c5d9dcb Add support for setting Image-property
OSC does not support to set volume's image property.
This patch will provide support for adding image property
to existing volume.

Closes-Bug:#1554877

Implements: bp cinder-command-support

Change-Id: I4ff5532c228f010789b81c7587dd4a2838a90f20
2016-03-16 14:17:34 +00:00
Jenkins
d88284c86d Merge "Add project options to security group create" 2016-03-16 05:19:15 +00:00
Jenkins
006d34fc82 Merge "Support "--long" option in ListService" 2016-03-14 20:17:04 +00:00
Jenkins
bbdef271b7 Merge "Add "os subnet create" command using SDK" 2016-03-14 16:09:56 +00:00
Jenkins
2f6b48e039 Merge "Use assertItemsEqual() instead of assertListEqual()" 2016-03-14 16:09:49 +00:00
Rui Chen
8664a2f8ae Support "--long" option in ListService
Add "--long" option in ListService so that compute service
disabled reason can be showed.

Change-Id: I1ace8f1c4e4efe0a1a8f6710425d73eb5db9e5e1
Closes-Bug: #1556815
2016-03-14 18:07:23 +08:00
Tang Chen
7b2e3c7d1c Use assertItemsEqual() instead of assertListEqual()
assertListEqual() is order sensitive. So we need to sort
the lists before we compare them. Use assertItemsEqual()
instead is better.

Change-Id: I9eaa98716c7401f5b099b007438acc916dae619b
2016-03-14 16:22:24 +08:00
Tang Chen
dc7e4fc15d Fix dict.keys() compatibility for python 3
In Python 2, dict.keys() will return a list.
But in Python 3, it will return an iterator.
So we need to fix all the places that assuming
dict.keys() is a list.

Change-Id: I8d1cc536377b3e5c644cfaa0892e40d0bd7c11b1
Closes-Bug: #1556350
2016-03-12 10:58:28 +08:00
Jenkins
586a038afd Merge "Fixed command list" 2016-03-11 20:48:32 +00:00
Richard Theis
a7c76878da Add project options to security group create
Add the --project and --project-domain options to the
'os security group create' command. These options are for Network v2
only.

Change-Id: I9e1667080a1a49389d51ade2e76a08b08a09870b
Closes-Bug: #1519511
Implements: blueprint neutron-client
2016-03-11 08:28:53 -06:00
Jenkins
3737c5a842 Merge "Trivial: Reorder classes in identity v3 in alphabetical order" 2016-03-11 05:44:01 +00:00
Jenkins
4856eb144a Merge "Enhance list extension unit test" 2016-03-11 04:50:26 +00:00
Fang Zhen
4208f02a20 Enhance list extension unit test
Extension list involves identity, compute, volume and network.
Current test covers only identity and network. This patch added test
against compute and volum. Also refactored current implentation.

Change-Id: If9b36cba24c50a817a17f685801e418fb898596a
2016-03-11 10:39:15 +08:00
Tang Chen
2debde35ef Trivial: Reorder classes in identity v3 in alphabetical order
Change-Id: Iaf2e336c2415416ec69f6b974743c26509bba561
2016-03-11 10:02:25 +08:00
Jenkins
e3e2f38920 Merge "Refactor security group create to use SDK" 2016-03-11 01:33:57 +00:00
Jenkins
d4b71ea890 Merge "Refactor security group show to use SDK" 2016-03-11 01:33:50 +00:00
Brad Behle
71b8919054 Add "os subnet create" command using SDK
Implement the openstack client subnet create command using SDK
calls.

Co-Authored-By: Terry Howe <terrylhowe@gmail.com>
Partially implements: blueprint neutron-client
Closes-Bug: #1542364

Change-Id: Ia6120b8dccf2ee83dc89b3f496f7180d4dc5199a
2016-03-10 16:20:03 -06:00
Richard Theis
ea2dd8e141 Refactor security group create to use SDK
Refactored the 'os security group create' command to use the SDK
when neutron is enabled, but continue to use the nova client
when nova network is enabled.

Added a release note for the change in security group rules output
due to Network v2. The tenant_id column name was fixed to align
with the 'os security group show' command.

Change-Id: Ib29df42edcddcc73a123fff6a64743a6bfcb7fbf
Partial-Bug: #1519511
Implements: blueprint neutron-client
2016-03-10 10:18:52 -06:00
Richard Theis
564c8ff240 Refactor security group show to use SDK
Refactored the 'os security group show' command to use the SDK
when neutron is enabled, but continue to use the nova client
when nova network is enabled.

Added a release note for the change in security group rules output
due to Network v2. The column names remain unchanged to maintain
backwards compatibility.

Change-Id: I25233ddb8115d18b8b88affb3de13346084a339d
Partial-Bug: #1519511
Implements: blueprint neutron-client
2016-03-10 08:33:52 -06:00
Jenkins
c6e46aa8da Merge "[Subnet pool] Add 'subnet pool create' command support" 2016-03-10 00:38:27 +00:00
Jenkins
cf0f229cad Merge "[Subnet pool] Add 'subnet pool set' command support" 2016-03-10 00:38:09 +00:00
Jenkins
f8ac17ac52 Merge "Trivial: Use 'SSH' rather than 'Ssh'" 2016-03-09 17:18:33 +00:00
Jenkins
1cef18427f Merge "Remove FakeFlavorResource class" 2016-03-09 17:18:26 +00:00
Jenkins
46f58dc173 Merge "remove py26 workaround in osc" 2016-03-09 16:40:46 +00:00
Brandon Palm
f0c3b4e69d Fixed command list
The cliff module expects an array of tuples however
the array that this function was returning was an array
of tuples that was also containing an array of values for
the commands attached to each group and the
cliff module wasn't liking it.

The output now comes out looking like:

| openstack.common | limits show |
|                  | extension list |
| openstack.baremetal.v1 | baremetal set |

Change-Id: Ifa1c149cb5c66ba27dc72bf72d7c8f2f50e42f73
Closes-Bug: 1545609
2016-03-09 16:00:39 +00:00
Stephen Finucane
13e2bb9b96 Trivial: Use 'SSH' rather than 'Ssh'
This is reflected in the '--help' screen.

Change-Id: Ic22a65ff6a56b069b37a0ea8365cce2b3f93621c
2016-03-09 14:55:55 +00:00
Jenkins
040d0c2e82 Merge "[Identity] Check return value is None in identity v3 unit tests" 2016-03-09 08:32:55 +00:00
Jenkins
c8e4a1407f Merge "Add --reason for disable service" 2016-03-09 07:12:51 +00:00
Tang Chen
237d7feca8 [Identity] Check return value is None in identity v3 unit tests
take_action() in commands inheriting from Command returns nothing.
So we should assert the return is None in the unit tests of these
commands.

Change-Id: I53eeb88316b2c20882fed97149d55cb04bcb2b2e
Closes-Bug: #1550636
2016-03-09 14:17:05 +08:00
jichenjc
b711c3a0ca Add --reason for disable service
disbale service allow a reason to be input as disable reason.
This patch add support for it.

Change-Id: I59622c3970e055ebd46bf03c33c864b6d064db28
2016-03-09 05:19:41 +00:00
Tang Chen
81930abdcb Remove FakeFlavorResource class
In unit tests, all real methods are faked. They should not
do any real operations in the tests. So, FakeFlavorResource
is not necessary. Just fake get_keys(), set_keys and unset_keys()
in FakeResource would be enough.

Change-Id: Icc3473ba9c77f4817d0edddb7ff3e1bd2946fac7
2016-03-09 10:26:15 +08:00
Jas
e0d58641bb Add 'port set' command
Add CLI support for the 'port set' command

Change-Id: I2bea508e11290284aa64b1ab548a0bb61e7290d3
Partial-bug: #1519909
Partially-implements: blueprint neutron-client
2016-03-08 09:48:50 -06:00
Jenkins
9ab7740dfd Merge "Trivial: Fix incorrect comments in compute fakes.py" 2016-03-08 15:15:41 +00:00
Tang Chen
3d741d3757 [Subnet pool] Add 'subnet pool create' command support
This patch supports creating a new subnet pool,
with pool prefixes, default prefix length, minimum
prefix length, and maximum prefix length specified.

Change-Id: I9150797c8cfa794d5264ad07965aa967d9a8f5bc
Partial-Bug: #1544586
Related-to: blueprint neutron-client
2016-03-08 21:22:13 +08:00
Tang Chen
f2fb007e82 [Subnet pool] Add 'subnet pool set' command support
This patch supports setting a new name, pool prefix,
default prefix length, minimum prefix length,
and maximum prefix length for a subnet pool.

Change-Id: I65bd71e0f54f2f65acefbc542df67a1b1ec26397
Partial-Bug: #1544591
Related-to: blueprint neutron-client
2016-03-08 21:22:13 +08:00