openstack/python-openstackclient
Code Issues Proposed changes
2,255 Commits 7 Branches 64 Tags
d906507962
Commit Graph

11 Commits

Author SHA1 Message Date
Akihiro Motoki
258c1102cc log take_action parameters in a single place 
Previously each command logs take_action parameters explicitly
by using @utils.log_method decorator or log.debug().
Some commands have no logging.

This commit calls a logger in the base class and
drops all logging definition from individual commands.

Closes-Bug: #1532294
Change-Id: I43cd0290a4353c68c075bade9571c940733da1be
 2016-02-02 09:58:32 +09:00
Tang Chen
494659fbe4 Trivial: Remove useless return from files in compute. 
Change-Id: I9dc6749256fcd53d292d7f658912c032e9ce9df5
 2015-12-17 09:34:12 +08:00
xiexs
ea63553925 Fix the bug of "openstack console log show" 
The behaviors are inconsistent while different
negative line numbers specified.

Change-Id: I2573f3e789f5603c896758971830ffc0b94c5e2b
Closes-Bug: #1512263
 2015-11-09 04:22:09 -05:00
Joshua Harlow
e3c46ece4a Use a common decorator to log 'take_action' activation 
Instead of duplicating the same log statement throughout
the code, the same logic can be provided by a shared decorator
that abstracts away the logging capability and unifies it behind
a common function instead.

Change-Id: Icc63bced7347c8bbf0299a4c5821425a10892a79
 2015-09-01 16:49:54 -07:00
Dean Troyer
9eb30efbf3 Command object docs: aggregate, console *, keypair 
aggregate
console log
console url
keypair

Change-Id: Iec9b8404ed5febd061a5dfd674b76aaa8aba67bc
 2014-11-19 14:47:53 -06:00
Dean Troyer
5bb6c72ef7 Normalize more help strings 
Change-Id: I2b21bc904e35c1cc50da369d148e607fe3e8cf90
 2014-07-24 11:22:29 -05:00
Christian Berendt
3b485de6b0 replace string format arguments with function parameters 
There are files containing string format arguments inside
logging messages. Using logging function parameters should
be preferred.

Change-Id: Ic749ac9eb55564ed631d57055a5a4dfc3aebd169
 2014-05-20 13:49:56 +02:00
Yejia Xu
3b57117f8e Display all server log when --lines option is None 
Without --lines option, `console log show xxx`
cmd will break.

Change-Id: I4027aacac245e6916c1808fd9f878fb708c8a5f0
Closes-Bug: #1316870
 2014-05-07 05:15:22 +00:00
Dean Troyer
dfb0e3e3c1 Begin Python 3 compatability 
* use six.iteritems()
* replace basestring with six.string_types
* convert print statements to functions (they're all debugging and should
  be removed eventually anyway)

* clean up OpenStack copyright: LLC -> Foundation

Change-Id: Icb14212bcb408e63816bfec3922a697bc1a6c946
 2013-07-29 19:12:29 -05:00
Steve Martinelli
1a0d5ccc68 Remove api = apiName calls from each method 
As discussed in https://review.openstack.org/#/c/36352/ for each
command, we were setting api = identity or volume... etc,
this was for an old way of calling commands that are is no longer
used.

Also removed openstackclient/common/command.py

Change-Id: I2705f35d343f2ae729dc22d6aed0b852b2f8ca19
 2013-07-12 11:07:33 -05:00
Dean Troyer
53bbff67eb Add console commands 
Adds:
* console-log
* console-url

Part of blueprint nova-client

Change-Id: Ibea7f96382283770988d05379d41a148f8cd8c4f
 2013-04-25 14:36:46 -05:00