1129 Commits

Author SHA1 Message Date
Huanxuan Ao
1c49a1f01d Fix NoneType error for volume snapshot create command
In volume snapshot command, <volume> is the same
as <snapshot-name> when --volume is not specified,
but <volume> cannot be None, so when <snapshot-name>
is not specified (<snapshot-name> is None), a NoneType
error appears.
So make <snapshot-name> no longer optional, it should
be always present.

Change-Id: I3d9f10753a8ef601e70816421c160598e2cc811f
Closes-bug: #1659894
2017-04-26 11:07:08 -05:00
Jenkins
7977f7df18 Merge "Add --network and --port to server create" 2017-04-25 13:54:46 +00:00
Jenkins
62d71aa243 Merge "Allow override of distributed router flag" 2017-04-17 15:18:20 +00:00
Rui Chen
a071ff91c3 Add document about renaming OS_ENDPOINT_TYPE to OS_INTERFACE
The patch https://review.openstack.org/#/c/198506/ rename option
--os-endpoint-type to --os-interface a year ago, but lots of users
switch to osc from these project specified clients, like: novaclient
and neutronclient, they used OS_ENDPOINT_TYPE and --os-endpoint-type
for long time, we should add the notes into openstackclient manpage,
let them know the gap exists, and how to make it works.

Change-Id: Ic84a60744aa4e519994a18104deae0c2b5b8b0ed
Closes-Bug: #1678144
2017-04-11 15:01:49 +08:00
David Rabel
8549071363 Add --network and --port to server create
--nic option is quite unhandy. It is better to have
two seperate options --network and --port to add a
network to a new server.

Change-Id: I523abdc83ca2dd4c5dd3871f8f109c2bf57c2e02
Closes-Bug: #1612898
2017-04-07 16:36:18 +02:00
venkata anil
fe59e339ae Allow override of distributed router flag
When router_distributed=True is set in neutron.conf,
user can't override this and create a centralized router
through openstack client. Openstack client allows modifying
routers from distributed to centralized after creation but
not supporting centralized flag during creation. We allow
centralized and distributed flags during router creation
with this change.

Closes-bug: #1664255
Change-Id: I75f72ca695338ad8c381cfa89fbb9d8e61ee7bc5
2017-04-06 14:37:14 +00:00
Jenkins
80726b1340 Merge ""floating ip set/unset port" for OSC" 2017-04-06 01:55:24 +00:00
Jenkins
8983373e52 Merge "Add "qos-policy" option to "port create" & "port set"" 2017-04-06 01:43:44 +00:00
Jenkins
27f96a3a7a Merge "Enable to create legacy router" 2017-04-05 17:00:49 +00:00
Sindhu Devale
763c8c5670 "floating ip set/unset port" for OSC
Implements Neutron feature of floating ip associate/disassociate
into OpenStack Client.

Previously, network.find_ip() function only supported to
search floating ip by UUID. Hence, _find_floating_ip()
function is used in floating_ip.py, to search fip both by UUID
and ip_address. [1] adds the ability to find fip object using both UUID
and ip_address. This functionality however, won't be available until
the SDK is released. Hence, we continue to use _find_floating_ip()
method, which was cleaned up by [2] to remove the use of ip_cache.
Once, the SDK is released, we will remove all the usage of
_find_floating_ip() method and instead only use network.find_ip().

[1] https://review.openstack.org/#/c/449879/2
[2] https://review.openstack.org/#/c/447938/

Change-Id: I6c5222287c46ca42365917d2deae70bdb626347
Co-Authored-By: Reedip<reedip.banerjee@nectechnologies.in>
Co-Authored-By: RuiChen<chenrui.momo@gmail.com>
Closes-Bug: #1560297
2017-04-05 16:12:40 +00:00
Ha Van Tu
5ff2cfd042 Add "qos-policy" option to "port create" & "port set"
This patch adds "qos-policy" option to "port create" command,
and "qos-policy", "no-qos-policy" options to "port set" command
and "qos-policy" option to "port unset".

Change-Id: I78072e1ff0dd30a2e23a0fb833ce6ab5cf246016
Co-Authored-By: Nguyen Phuong An <AnNP@vn.fujitsu.com>
Co-Authored-By: Rodolfo Alonso Hernandez <rodolfo.alonso.hernandez@intel.com>
Partial-Bug: #1612136
Partially-Implements: blueprint network-commands-options
2017-04-05 15:56:52 +00:00
Jenkins
65b61d3a9c Merge "Enable to specify which fixed-ip to add to a vm." 2017-04-05 02:55:11 +00:00
Cedric Brandily
7f9814860a Enable to specify which fixed-ip to add to a vm.
This change enables to specify which fixed-ip will be added to a vm using:

 openstack server add fixed ip <vm> <network> --fixed-ip-address <ip>

This change uses interface_attach instead of add_fixed_ip[1] which is
less flexible and uses a deprecated API.

[1] https://review.openstack.org/384261

Closes-Bug: #1678140
Change-Id: I7fe4621439ef0d8dca080551ffaeb614c5a91174
2017-04-04 11:15:29 -05:00
Shashank Kumar Shankar
abb2498e71 Correct flavor associate/disassociate commands in Mapping Guide
This patch fixes the neutron CLI mapping for neutron flavor-associate
and flavor-disassociate since [1] got merged.

[1] - https://review.openstack.org/#/c/403907/

Change-Id: Ifd09a8b091ae89c33a06590aba935df5e22e215b
2017-04-04 15:45:46 +00:00
Jenkins
c7e7f2b730 Merge "Help/docs cleanups: marker, limit, ip-address metavars" 2017-04-04 12:32:55 +00:00
Dean Troyer
1686dc54f0 Help/docs cleanups: marker, limit, ip-address metavars
Cleanup help strings and docs for clarity and to keep things consistent:
* --limit metavar should be <num-resource> to indicate what is being counted
* --marker metavar should be <resource> or <resource-id> to indicate the
  type of value being specified
* <*-ip-address> metavars should be just <ip-address> as there is no difference
  in format between fixed and floating IPs
* Move all occurances of '(name or ID)' to end of help text

Change-Id: I2c31746ed6ded3845244e03e57d809f8bc0e6b9d
2017-04-04 03:56:19 +00:00
Jenkins
8a1f4b6592 Merge "Introduce neutron flavor associate, disassociate to OSC" 2017-04-04 02:38:59 +00:00
Jenkins
d0f368ba0e Merge "Enable to add/remove port to/from a server" 2017-04-03 20:51:20 +00:00
Cedric Brandily
21510ac1a9 Enable to add/remove port to/from a server
This change enables to add/remove a specific port to/from a server using
the new commands:

 openstack server add port <vm> <port>
 openstack server remove port <vm> <port>

Closes-Bug: #1678137
Change-Id: I6ee57df089235ccc1fb9d38316bd484956b1134d
2017-04-03 20:19:40 +02:00
Shashank Kumar Shankar
b51310a4bb Introduce neutron flavor associate, disassociate to OSC
This patch introduces network flavor associate and disassociate to
OSC. The following neutron equivalent commands are implemented in OSC:

    - neutron flavor-associate
    - neutron flavor-disassociate

Change-Id: Icba4dbf7300a36353142586359059cd6784049dc
2017-04-03 17:02:03 +00:00
Jenkins
67a4b812c6 Merge "doc: Correct Sphinx warnings" 2017-04-01 21:08:43 +00:00
Jenkins
e059adeab7 Merge "doc: Remove local fork of apidoc" 2017-04-01 21:07:29 +00:00
Cedric Brandily
53ba05325a Enable to create legacy router
Some deployments create by default HA routers, this change enables to
force the creation of a legacy router using:

 openstack router create --no-ha ...

Closes-Bug: #1675514
Change-Id: I78f7dc3640a2acfdaf085e0e387b30373e8415f1
2017-03-31 13:01:00 +00:00
Stephen Finucane
70170656fd doc: Correct Sphinx warnings
- Fix option-describe typos
- Correct option and envvar markup, for commands that are using the
  reference form instead of the definition form or are marking up
  option arguments as options
- Avoid duplicate commands
- Fix some invalid docstrings
- Fix some invalid indentation
- Disable the murano plugin, which has invalid docs
- Correct issues with- and track the network-topology spec
- Include API modules in docs

Change-Id: I3d5ed5e872540fe13f3e4bd5e9335829dc9a5226
2017-03-28 16:41:54 +01:00
Stephen Finucane
9f471eede9 doc: Remove local fork of apidoc
This is unnecessary as pbr has since been fixed. It was causing a broken
build as it didn't respect the '[pbr] autodoc_tree_excludes' setting in
setup.cfg.

The 'openstackclient/volume/v3' directory is an empty module containing
only an '__init__' file). Empty modules = unhappy autodoc, thus, this
module is ignored.

Change-Id: Ie355b14c14b7badccb5c25f7c17edbc5e4b3804f
2017-03-28 16:29:19 +01:00
Dean Troyer
709eac73fb Fix volume transfers request commands
* Fix volume transfer request accept to actually not crash when
  trying to call Volume API.
* Fix volume transfer request accept syntax to have only one
  positional argument, which is the ID of the resource in the command
* Change the output column order in volume transfer request list to
  have ID followed by Name then the remaining columns.

Closes-bug: 1633582
Change-Id: I5cc005f039d171cc70859f60e7fe649b09ead229
2017-03-27 12:31:42 -05:00
Ankur Gupta
c3fee25a07 Doc: Fix link in network flavors
Rendered incorrectly.

Change-Id: I206dd8affa45864e406796147665c94684e9bf4d
2017-03-24 12:19:53 -05:00
Jenkins
2a64a64046 Merge "OSC Extension Show" 2017-03-23 20:30:15 +00:00
Jenkins
5da7ddd703 Merge "docs: Don't include ChangeLog" 2017-03-23 16:51:29 +00:00
Sindhu Devale
832b2591cf OSC Extension Show
Implement Neutron feature of Extension Show into
OpenStack Client.

Change-Id: Ifecb794838cb3bf8c2466d178345349db3cd4003
Implements: blueprint extension-show
2017-03-22 16:39:19 +00:00
Jenkins
b5d707eb7b Merge "Support to add/remove multi users for "group add/remove user"" 2017-03-21 17:20:48 +00:00
Jenkins
2fdd4ff2f6 Merge "Fix Trivial Changes in [1]" 2017-03-21 08:29:27 +00:00
Jenkins
6329c04297 Merge "OSC Quota List" 2017-03-21 03:56:05 +00:00
Jenkins
efc570dae2 Merge "OSC Network Flavor Profile" 2017-03-21 03:32:47 +00:00
Reedip
8e2bc9cb9c Fix Trivial Changes in [1]
[1] had some trivial changes in the main code, which
are being put forward in this patch, to consider future scenarios.

[1]: I77a933f4b3ce875c63cef5b6a32aee78fd844b03

TrivialFix

Change-Id: I8e8fbb194cd319e5605f09c94ae09e952d0961b1
2017-03-21 02:43:24 +00:00
Huanxuan Ao
ef5a7caf85 Support to add/remove multi users for "group add/remove user"
Similar delete commands in OSC, we can also support add/remove
multi users for one specified group, this review implement it.

Change-Id: I8ccf99d4ee83a18778fa3ff5c0a42bc7c6ff21fb
Implements: bp support-multi-add-remove
2017-03-21 10:39:42 +08:00
Jenkins
49e866174f Merge "Enable to specify which vm fixed-ip to publish" 2017-03-21 01:55:51 +00:00
Cedric Brandily
f5527877bb Enable to specify which vm fixed-ip to publish
This change enables to specify which vm fixed-ip will be associated to a
floating ip using:

 openstack server add floating ip <vm> <fip> --fixed-ip-address <ip>

Closes-Bug: #1624524
Change-Id: I2ddb68c5873bfed7293b0e661d1adbe111681136
2017-03-20 22:33:51 +01:00
Jenkins
3e621c9a9c Merge "Introduce Neutron DHCP agent commands to OSC" 2017-03-20 21:31:53 +00:00
Jenkins
f16513aaf2 Merge "Make MAC address of port updatable" 2017-03-20 20:53:22 +00:00
Shashank Kumar Shankar
f4fd8f6e31 Introduce Neutron DHCP agent commands to OSC
This patch introduces neutron dhcp-agent related commands to OpenStack
client.

The equivalent neutron commands implemented in OSC:

neutron: dhcp-agent-list-hosting-net
OSC: network agent list --network

neutron: dhcp-agent-network-add
OSC: network agent add network

neutron: dhcp-agent-network-remove
OSC: network agent remove network

neutron: net-list-on-dhcp-agent
OSC: network list --agent

Change-Id: I77a933f4b3ce875c63cef5b6a32aee78fd844b03
2017-03-20 15:02:09 -04:00
Jenkins
9a1efd41c8 Merge "Non-Admin can't list own projects" 2017-03-20 17:58:38 +00:00
Jenkins
97a4ac471a Merge "Add extra filtering options to qos policy list" 2017-03-20 17:58:32 +00:00
Stephen Finucane
be1e6ca1d8 docs: Don't include ChangeLog
The ChangeLog is built using commit message summary lines. Unfortunately
some of these contain invalid rST markup. There's no way to
retroactively fix this, so simply stop including the doc.

Change-Id: I6600c1baf142fe4c776f1ae170faa3f6a87b330c
2017-03-20 16:35:01 +00:00
Nakul Dahiwade
7ef1e9ea96 OSC Network Flavor Profile
Implement Neutron feature of Network Flavor Profile
into OpenstackClient
This patch implements the following commands:
network flavor profile create
network flavor profile delete
network flavor profile list
network flavor profile show
network flavor profile set

SDK Version needed: 0.9.9

Change-Id: Ie6fe5e53122cfb2eda8d326851d54562739a8386
Partially-Implements: blueprint neutron-client-flavors
2017-03-20 16:24:27 +00:00
Bence Romsics
f1345dc06f Make MAC address of port updatable
openstackclient does not allow the update of a port's MAC address.
However this is possible in neutron API (though by default policy
it is an admin-only operation). Allow it in openstackclient too.

Change-Id: Ibd9e0a6fbd1d0d461b8a8daee24dbb7c3f929df6
Closes-Bug: #1670707
2017-03-20 15:40:48 +00:00
adrian-turjak
49f6032b69 Non-Admin can't list own projects
Due to a default Keystone policy until Newtown,
and the use of resource_find, non-admins are unable
to list their own projects.

This patch bypasses this problem while also introducing better
UX for non-admins wishing to get their project list.

'openstack project list' retains the default of 'list all projects'
but on a forbidden error will default instead to 'list my projects'.
This way for non-admins 'list my projects' feels like the default
without breaking the expected admin default.

Adding the '--my-projects' option allows admins to easily list their
own projects or allows non-admins to be explicit and bypass the
forbidden error fallback.

Change-Id: I1021276f69fbbf28e13e17c4e567d932fce7ed8b
Closes-Bug: #1627555
2017-03-20 14:40:56 +13:00
Jenkins
9184e19288 Merge "Add sort support to project list" 2017-03-16 13:01:56 +00:00
lvjiawei
9fd3dba11e Add extra filtering options to qos policy list
The patch adds filtering "--project", "--project-domain",
"--share", "--no-share" options to qos policy list.

Change-Id: I5c012fb27fb952f736ddc9fbc54ef6da4d0af5e0
Partially-Implements: blueprint network-commands-options
2017-03-14 13:04:47 +08:00
Jenkins
4a19f6753b Merge "Fix reference in network flavor create command reference" 2017-03-12 19:49:52 +00:00