openstack/python-openstackclient
Code Issues Proposed changes
2,180 Commits 7 Branches 64 Tags
f0c3b4e69d
Commit Graph

20 Commits

Author SHA1 Message Date
Tang Chen
fc24f37ae2 Trivial: Remove useless return 
If a function returns nothing, do not add return in the end.

Change-Id: I298b8717462f68d3076a1619d674775be2a94c42
 2016-03-07 17:54:06 +08:00
Akihiro Motoki
258c1102cc log take_action parameters in a single place 
Previously each command logs take_action parameters explicitly
by using @utils.log_method decorator or log.debug().
Some commands have no logging.

This commit calls a logger in the base class and
drops all logging definition from individual commands.

Closes-Bug: #1532294
Change-Id: I43cd0290a4353c68c075bade9571c940733da1be
 2016-02-02 09:58:32 +09:00
Jude Job
a2a63f19bf Implementation for project unset cmd for python-openstackclient. 
This patch introduces a unit test class TestProjectUnset
for testing unset cmd.

Co-Authored-By: Steve Martinelli <stevemar@ca.ibm.com>
Change-Id: Ib4a414d2313e3d37e48d1cb3639f064231aec508
Closes-Bug: #1486597
 2016-01-04 10:25:55 -05:00
Dean Troyer
bf090c69c2 Switch to ksa Session 
* Change session imports to keystoneauth1
* Change keystoneclient.exception imports to keystoneauth1
* Change exceptions raised from internal API from keystoneclient to openstack.common

Change-Id: I046d89f561d6fe04baae53726f9749d2e7fe2056
 2015-12-02 01:55:14 +00:00
Joshua Harlow
e3c46ece4a Use a common decorator to log 'take_action' activation 
Instead of duplicating the same log statement throughout
the code, the same logic can be provided by a shared decorator
that abstracts away the logging capability and unifies it behind
a common function instead.

Change-Id: Icc63bced7347c8bbf0299a4c5821425a10892a79
 2015-09-01 16:49:54 -07:00
Steve Martinelli
019c155e9b Fine tune some of the helps commands 
try and add some consistency with the show and delete commands.

replace 'show x' with 'display x'
change 'delete a y' with just 'delete y'

Change-Id: I47dfa8ee23ac5c41b355796415eb515155832f65
 2015-01-13 00:58:57 -05:00
wanghong
d8f1cbd984 add multi-delete support for identity 
This is part2. Add support for these objects:
identity.project(v2.0)
identity.role(v2.0)
identity.user(v2.0)
identity.project(v3)
identity.role(v3)
identity.user(v3)
identity.group(v3)

Closes-Bug: #1400597
Change-Id: I270434d657cf4ddc23c3aba2c704d6ef184b0dbc
 2014-12-23 09:39:29 +08:00
Jamie Lennox
25a7c1f27f Don't import form keystoneclient.openstack.common 
The keystoneclient.openstack.common directory is where we sync files
from oslo incubator. It is not a public directory and should not be
being consumed by openstackclient.

Change-Id: I011bb95c2c824e2dbc4b822ca922ae77b8d9b955
 2014-12-17 18:17:56 +10:00
Steve Martinelli
13672123fc Safely pop project parent id 
Since we don't support multitenancy yet, we should just pop the
parent id of a project. When keystoneclient supports mulittenancy
we should bring everything in at once (CRUD), and these changes
should be removed.

Change-Id: I82c7c825502124a24ccdbadf09ecb2748887ca5d
 2014-12-04 15:34:02 -05:00
Dean Troyer
04d30c1855 Command object docs: project, role, user 
project
role
user
user role

Change-Id: I445e09a3ffb69114912ae562a9285963a636bfd1
 2014-12-01 17:36:20 -05:00
Steve Martinelli
7242113a8f Add additional support for --or-show 
Add --or-show for the following:
  * v2 roles
  * v2 projects

Change-Id: Ibbae19cda668575b9527fbd259f1298c48b8265b
 2014-11-14 16:29:57 -05:00
Steve Martinelli
bb71df9ced Mark identity v2 resources for translation 
mark v2 catalog, ec2, endpoint, project, role, service and token

Change-Id: I14a5852bfee4ca9e25130d001fdadd7778ad0996
 2014-10-09 14:16:45 -04:00
Dean Troyer
845de41635 Return current user/project for user/project show commands 
If non-admin user attempts 'project show' or 'user show' on the currently
authenticated project or user return the information that is already in the
service catalog rather than throwing a Forbidden error.

Change-Id: Ieeb6eacf71a471e410fbd3c09e7871740547e890
 2014-09-14 22:53:35 -05:00
Jenkins
3b925e9806 Merge "replace string format arguments with function parameters" 2014-06-10 02:27:54 +00:00
Alex Gaynor
a8087a6c8b Fixed several typos throughout the codebase 
Change-Id: I048ee857fc1215fea7f60978364894e1b5abdf66
 2014-05-21 07:47:52 -07:00
Christian Berendt
3b485de6b0 replace string format arguments with function parameters 
There are files containing string format arguments inside
logging messages. Using logging function parameters should
be preferred.

Change-Id: Ic749ac9eb55564ed631d57055a5a4dfc3aebd169
 2014-05-20 13:49:56 +02:00
Terry Howe
70e6333e7d Add ability to set key value pairs in projects 
Add supporto of extra key value pairs for projects (aka tenants)
* Added option --property key=value to create and set commands
* Support for versions v2 and v3

Change-Id: I84064b8b308579d1b66c83b1ed3d1a37614ec087
Closes-Bug: #1220280
 2014-03-06 14:22:17 -07:00
Dean Troyer
7a0a7d67ed Prepare for Identity v3 tests 
* Split identity/fakes.py for v2_0 and v3
* Split identity/test_identity.py for v2_0 and v3
* Fix issues in commands with enable/disable
* Clean up v2 commands

Change-Id: I6e536b6a130fc556dbd7dcf9f2e76d939ca1bc1c
 2013-09-09 14:52:50 -05:00
Dean Troyer
493339d4da Add Identity v2 project tests 
* establish the the form of cliff command classes
* implement some common fake objects
* implement Identity command tests for v2 project
* fix stdout/stderr capture

Also re-work the project create and set commands for exclusive options
(--enable|--disable) to actually behave properly.  Yay tests!

Change-Id: Icbb313db544c1f8dd3c9af7709971838b5a4d115
 2013-08-16 14:35:46 -05:00
Dean Troyer
c385180df2 Remove tenant round 2 - Identity API 
Rename everything in the Identity v2 code including the file and classes.
* role, tenant, user

Change-Id: I0b99c60a24f5875120136d2f216aa3b6bce1c641
 2013-07-31 10:10:45 -05:00