1. As mentioned in [1], we should avoid using six.iteritems to achieve iterators. We can use dict.items instead, as it will return iterators in PY3 as well. And dict.items/keys will more readable. 2. In py2, the performance about list should be negligible, see the link [2]. [1] https://wiki.openstack.org/wiki/Python3 [2] http://lists.openstack.org/pipermail/openstack-dev/2015-June/066391.html Co-Authored-By: Akihiro Motoki <amotoki@gmail.com> Change-Id: I4b9edb326444264c0f6c4ad281acaac356a07e85 Implements: blueprint replace-iteritems-with-items
		
			
				
	
	
		
			214 lines
		
	
	
		
			7.1 KiB
		
	
	
	
		
			Python
		
	
	
	
	
	
			
		
		
	
	
			214 lines
		
	
	
		
			7.1 KiB
		
	
	
	
		
			Python
		
	
	
	
	
	
#   Licensed under the Apache License, Version 2.0 (the "License"); you may
 | 
						|
#   not use this file except in compliance with the License. You may obtain
 | 
						|
#   a copy of the License at
 | 
						|
#
 | 
						|
#        http://www.apache.org/licenses/LICENSE-2.0
 | 
						|
#
 | 
						|
#   Unless required by applicable law or agreed to in writing, software
 | 
						|
#   distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
 | 
						|
#   WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
 | 
						|
#   License for the specific language governing permissions and limitations
 | 
						|
#   under the License.
 | 
						|
#
 | 
						|
 | 
						|
"""Service Provider action implementations"""
 | 
						|
 | 
						|
import logging
 | 
						|
 | 
						|
from osc_lib.command import command
 | 
						|
from osc_lib import exceptions
 | 
						|
from osc_lib import utils
 | 
						|
 | 
						|
from openstackclient.i18n import _
 | 
						|
 | 
						|
 | 
						|
LOG = logging.getLogger(__name__)
 | 
						|
 | 
						|
 | 
						|
class CreateServiceProvider(command.ShowOne):
 | 
						|
    _description = _("Create new service provider")
 | 
						|
 | 
						|
    def get_parser(self, prog_name):
 | 
						|
        parser = super(CreateServiceProvider, self).get_parser(prog_name)
 | 
						|
        parser.add_argument(
 | 
						|
            'service_provider_id',
 | 
						|
            metavar='<name>',
 | 
						|
            help=_('New service provider name (must be unique)'),
 | 
						|
        )
 | 
						|
        parser.add_argument(
 | 
						|
            '--auth-url',
 | 
						|
            metavar='<auth-url>',
 | 
						|
            required=True,
 | 
						|
            help=_('Authentication URL of remote federated service provider '
 | 
						|
                   '(required)'),
 | 
						|
        )
 | 
						|
        parser.add_argument(
 | 
						|
            '--description',
 | 
						|
            metavar='<description>',
 | 
						|
            help=_('New service provider description'),
 | 
						|
        )
 | 
						|
        parser.add_argument(
 | 
						|
            '--service-provider-url',
 | 
						|
            metavar='<sp-url>',
 | 
						|
            required=True,
 | 
						|
            help=_('A service URL where SAML assertions are being sent '
 | 
						|
                   '(required)'),
 | 
						|
        )
 | 
						|
 | 
						|
        enable_service_provider = parser.add_mutually_exclusive_group()
 | 
						|
        enable_service_provider.add_argument(
 | 
						|
            '--enable',
 | 
						|
            dest='enabled',
 | 
						|
            action='store_true',
 | 
						|
            default=True,
 | 
						|
            help=_('Enable the service provider (default)'),
 | 
						|
        )
 | 
						|
        enable_service_provider.add_argument(
 | 
						|
            '--disable',
 | 
						|
            dest='enabled',
 | 
						|
            action='store_false',
 | 
						|
            help=_('Disable the service provider'),
 | 
						|
        )
 | 
						|
 | 
						|
        return parser
 | 
						|
 | 
						|
    def take_action(self, parsed_args):
 | 
						|
        service_client = self.app.client_manager.identity
 | 
						|
        sp = service_client.federation.service_providers.create(
 | 
						|
            id=parsed_args.service_provider_id,
 | 
						|
            auth_url=parsed_args.auth_url,
 | 
						|
            description=parsed_args.description,
 | 
						|
            enabled=parsed_args.enabled,
 | 
						|
            sp_url=parsed_args.service_provider_url)
 | 
						|
 | 
						|
        sp._info.pop('links', None)
 | 
						|
        return zip(*sorted(sp._info.items()))
 | 
						|
 | 
						|
 | 
						|
class DeleteServiceProvider(command.Command):
 | 
						|
    _description = _("Delete service provider(s)")
 | 
						|
 | 
						|
    def get_parser(self, prog_name):
 | 
						|
        parser = super(DeleteServiceProvider, self).get_parser(prog_name)
 | 
						|
        parser.add_argument(
 | 
						|
            'service_provider',
 | 
						|
            metavar='<service-provider>',
 | 
						|
            nargs='+',
 | 
						|
            help=_('Service provider(s) to delete'),
 | 
						|
        )
 | 
						|
        return parser
 | 
						|
 | 
						|
    def take_action(self, parsed_args):
 | 
						|
        service_client = self.app.client_manager.identity
 | 
						|
        result = 0
 | 
						|
        for i in parsed_args.service_provider:
 | 
						|
            try:
 | 
						|
                service_client.federation.service_providers.delete(i)
 | 
						|
            except Exception as e:
 | 
						|
                result += 1
 | 
						|
                LOG.error(_("Failed to delete service provider with "
 | 
						|
                          "name or ID '%(provider)s': %(e)s"),
 | 
						|
                          {'provider': i, 'e': e})
 | 
						|
 | 
						|
        if result > 0:
 | 
						|
            total = len(parsed_args.service_provider)
 | 
						|
            msg = (_("%(result)s of %(total)s service providers failed"
 | 
						|
                   " to delete.") % {'result': result, 'total': total})
 | 
						|
            raise exceptions.CommandError(msg)
 | 
						|
 | 
						|
 | 
						|
class ListServiceProvider(command.Lister):
 | 
						|
    _description = _("List service providers")
 | 
						|
 | 
						|
    def take_action(self, parsed_args):
 | 
						|
        service_client = self.app.client_manager.identity
 | 
						|
        data = service_client.federation.service_providers.list()
 | 
						|
 | 
						|
        column_headers = ('ID', 'Enabled', 'Description', 'Auth URL')
 | 
						|
        return (column_headers,
 | 
						|
                (utils.get_item_properties(
 | 
						|
                    s, column_headers,
 | 
						|
                    formatters={},
 | 
						|
                ) for s in data))
 | 
						|
 | 
						|
 | 
						|
class SetServiceProvider(command.Command):
 | 
						|
    _description = _("Set service provider properties")
 | 
						|
 | 
						|
    def get_parser(self, prog_name):
 | 
						|
        parser = super(SetServiceProvider, self).get_parser(prog_name)
 | 
						|
        parser.add_argument(
 | 
						|
            'service_provider',
 | 
						|
            metavar='<service-provider>',
 | 
						|
            help=_('Service provider to modify'),
 | 
						|
        )
 | 
						|
        parser.add_argument(
 | 
						|
            '--auth-url',
 | 
						|
            metavar='<auth-url>',
 | 
						|
            help=_('New Authentication URL of remote '
 | 
						|
                   'federated service provider'),
 | 
						|
        )
 | 
						|
 | 
						|
        parser.add_argument(
 | 
						|
            '--description',
 | 
						|
            metavar='<description>',
 | 
						|
            help=_('New service provider description'),
 | 
						|
        )
 | 
						|
        parser.add_argument(
 | 
						|
            '--service-provider-url',
 | 
						|
            metavar='<sp-url>',
 | 
						|
            help=_('New service provider URL, where SAML assertions are sent'),
 | 
						|
        )
 | 
						|
        enable_service_provider = parser.add_mutually_exclusive_group()
 | 
						|
        enable_service_provider.add_argument(
 | 
						|
            '--enable',
 | 
						|
            action='store_true',
 | 
						|
            help=_('Enable the service provider'),
 | 
						|
        )
 | 
						|
        enable_service_provider.add_argument(
 | 
						|
            '--disable',
 | 
						|
            action='store_true',
 | 
						|
            help=_('Disable the service provider'),
 | 
						|
        )
 | 
						|
        return parser
 | 
						|
 | 
						|
    def take_action(self, parsed_args):
 | 
						|
        federation_client = self.app.client_manager.identity.federation
 | 
						|
 | 
						|
        enabled = None
 | 
						|
        if parsed_args.enable is True:
 | 
						|
            enabled = True
 | 
						|
        elif parsed_args.disable is True:
 | 
						|
            enabled = False
 | 
						|
 | 
						|
        federation_client.service_providers.update(
 | 
						|
            parsed_args.service_provider,
 | 
						|
            enabled=enabled,
 | 
						|
            description=parsed_args.description,
 | 
						|
            auth_url=parsed_args.auth_url,
 | 
						|
            sp_url=parsed_args.service_provider_url,
 | 
						|
        )
 | 
						|
 | 
						|
 | 
						|
class ShowServiceProvider(command.ShowOne):
 | 
						|
    _description = _("Display service provider details")
 | 
						|
 | 
						|
    def get_parser(self, prog_name):
 | 
						|
        parser = super(ShowServiceProvider, self).get_parser(prog_name)
 | 
						|
        parser.add_argument(
 | 
						|
            'service_provider',
 | 
						|
            metavar='<service-provider>',
 | 
						|
            help=_('Service provider to display'),
 | 
						|
        )
 | 
						|
        return parser
 | 
						|
 | 
						|
    def take_action(self, parsed_args):
 | 
						|
        service_client = self.app.client_manager.identity
 | 
						|
        service_provider = utils.find_resource(
 | 
						|
            service_client.federation.service_providers,
 | 
						|
            parsed_args.service_provider,
 | 
						|
            id=parsed_args.service_provider)
 | 
						|
 | 
						|
        service_provider._info.pop('links', None)
 | 
						|
        return zip(*sorted(service_provider._info.items()))
 |