openstack/python-openstackclient
Code Issues Proposed changes
681d6dc2de
python-openstackclient/releasenotes/notes
History
Huanxuan Ao 681d6dc2de Make "flavor show" command to show a private flavor properly 
The "flavor show" command could not show a
private flavor by flavor name becauce it could
not find a private flavor by flavor name.
In "until.find_resource(parsed_args.flavor)",
If parsed_args.falvor is a name of a flavor,
"flavors.find(name=parsed_args.flavor)"will be
called to find a flavor.But the default value of
"is_public" is "Ture" in "flavors.find()" so that
we can only find public flavors.If we want to find
all flaovrs by flavor name,we should add
"is_public=None" in "flavors.find()".

So I tried to change
"until.find_resource(parsed_args.flavor)" to
"until.find_resource(parsed_args.flavor, is_public=None)",
but then I could not find any flavor by flavor id
because "is_public" is an unexpected argument of
"flavors.get()" in "until.find_resource()".

In this case,I think "until.find_resource()"
can not find a private flavor properly,and
we should combine "manager.get(flavor.id)" and
"manager.find(name=flavor.name, is_public=None)"
by ourselve to find a flavor.

Also,this bug affects other flavor commands like
"flavor set/unset/delete",so I fix them in this patch too.

Change-Id: I4a4ed7b0a2f522ee04d1c3270afcda7064285c39
Closes-Bug: #1575478
2016-05-02 16:47:53 +08:00
..
.placeholder Add reno for release notes management 2015-12-02 14:32:07 -06:00
add-disable-reason-6e0f28459a09a60d.yaml Clean up release notes since 2.2.0 release 2016-04-07 10:54:41 -05:00
add-ksa-7f0795157d93a898.yaml Convert 2.0 release notes to reno format 2015-12-02 14:57:27 -06:00
add-osprofiler-support-adf5286daf220914.yaml Add shell --profile option to trigger osprofiler from CLI 2016-02-25 20:13:27 +00:00
add-port-commands-a3580662721a6312.yaml Clean up for next release 2016-04-18 14:19:27 -05:00
add-port-delete-command-4789d3881b186cfc.yaml Add support to delete the ports 2016-01-20 10:29:16 +05:30
add-port-show-command-de0a599017189a21.yaml Add "os port show" command 2016-02-02 08:40:05 -06:00
add-restore-server-d8c73e0e83df17dd.yaml Clean up release notes since 2.2.0 release 2016-04-07 10:54:41 -05:00
add-server-group-command-fde165df53216726.yaml Add "server group show" command 2016-04-20 03:26:13 +00:00
add-subnet-list-command-970f4b397469bdc6.yaml Add releasenote for 'subnet list' command support 2016-01-25 21:30:09 +00:00
allow-custom-logging-12d55f8ed859ff8e.yaml Add release note for custom logging feature 2016-02-07 01:23:19 +00:00
bug-1475831-3caafd724d4ed644.yaml Convert 2.0 release notes to reno format 2015-12-02 14:57:27 -06:00
bug-1486597-857e20262c038514.yaml Add missing release notes 2016-02-02 02:02:42 +00:00
bug-1516661-757ef629f899cca3.yaml Add missing release notes 2016-02-02 02:02:42 +00:00
bug-1517134-9efecb257910989c.yaml Add missing release notes 2016-02-02 02:02:42 +00:00
bug-1517386-1c0aad8e3203b02b.yaml Convert 2.0 release notes to reno format 2015-12-02 14:57:27 -06:00
bug-1519181-932c1ff07ef16666.yaml Fix formatting in release 2.0.0 notes 2016-02-05 16:25:01 -06:00
bug-1519502-d534db6c18adef20.yaml Clean up for next release 2016-04-18 14:19:27 -05:00
bug-1519502-f72236598d14d350.yaml Add incompatibility info for "ip floating list" command 2016-03-11 16:38:48 +08:00
bug-1519503-978a68a54819dbbc.yaml Add missing release notes 2016-02-02 02:02:42 +00:00
bug-1519510-3cde4643b33ebb7a.yaml Convert 2.0 release notes to reno format 2015-12-02 14:57:27 -06:00
bug-1519511-65b8901ae6ea2e63.yaml Clean up release notes since 2.2.0 release 2016-04-07 10:54:41 -05:00
bug-1519511-65d8d21dde31e5e2.yaml Add project options to security group create 2016-03-11 08:28:53 -06:00
bug-1519511-74bab0e0d32db043.yaml Add release note for security group set refactor 2016-03-05 10:18:35 -06:00
bug-1519512-48d98f09e44220a3.yaml Add project options to security group rule create 2016-04-11 10:05:24 -05:00
bug-1519512-65df002102b7fb99.yaml Add options to security group rule list 2016-04-18 14:03:22 -05:00
bug-1519512-4231ac6014109142.yaml Refactor security group rule create to use SDK 2016-03-23 09:56:01 -05:00
bug-1519512-48624c5a32432a47.yaml Add "security group rule show" command 2016-02-23 15:27:06 +00:00
bug-1519512-d20f44aca1f9e9b9.yaml Add missing release notes 2016-02-02 02:02:42 +00:00
bug-1520003-505af921c8afffc9.yaml Fix some release note formatting 2016-02-05 15:38:59 -06:00
bug-1520115-0367e1c8917dc912.yaml Fix formatting in release 2.0.0 notes 2016-02-05 16:25:01 -06:00
bug-1520541-44d45e4693089c03.yaml Fix formatting in release 2.0.0 notes 2016-02-05 16:25:01 -06:00
bug-1521492-8cde2601591a8c78.yaml Add missing release notes 2016-02-02 02:02:42 +00:00
bug-1521492-89b972c6362940a5.yaml Add missing release notes 2016-02-02 02:02:42 +00:00
bug-1522969-63abf273c6e71a07.yaml Add missing release notes 2016-02-02 02:02:42 +00:00
bug-1524456-9967fac653c91cb2.yaml Add missing release notes 2016-02-02 02:02:42 +00:00
bug-1525805-122e6ce0c3cd4945.yaml Add missing release notes 2016-02-02 02:02:42 +00:00
bug-1527833-42cde11d28b09ac3.yaml Fix some release note formatting 2016-02-05 15:38:59 -06:00
bug-1531360-0f5c62d18088e5b5.yaml Support non-interactive user password update 2016-01-11 09:27:10 -08:00
bug-1532945-1a5485b8d0ebddb8.yaml Fix some release note formatting 2016-02-05 15:38:59 -06:00
bug-1534202-1ba78f0bb744961f.yaml Fix some release note formatting 2016-02-05 15:38:59 -06:00
bug-1538372-ef3a30298357f972.yaml Add support for triggering an crash dump 2016-02-05 21:48:41 +08:00
bug-1540656-f7b7b7e3feef2440.yaml Support security group name for --src-group 2016-03-23 10:05:08 -05:00
bug-1540988-17841cfd5accf7f5.yaml Add --marker option to "image list" command 2016-02-03 14:04:50 +08:00
bug-1542359-181d28db21a2358a.yaml Add "os subnet show" command using SDK 2016-02-22 13:04:25 -06:00
bug-1542362-ddad607f6d3025f0.yaml Subnet: Add "subnet delete" command using SDK 2016-03-01 11:26:27 +09:00
bug-1542364-5d1e93cfd24f0b65.yaml Add "os subnet create" command using SDK 2016-03-10 16:20:03 -06:00
bug-1543214-959aee7830db2b0d.yaml Support unscoped token request 2016-02-19 16:07:13 -08:00
bug-1543226-7d885ecaa3715415.yaml Add "token revoke" for identity v3 2016-02-09 16:49:11 -08:00
bug-1543672-bad2fc4c6c8f3125.yaml Support "network create" command in nova network 2016-03-02 14:39:00 +08:00
bug-1544586-0e6ca9a09dac0726.yaml Clean up release notes since 2.2.0 release 2016-04-07 10:54:41 -05:00
bug-1544586-0fe19a567d3e31fc.yaml Add new share and default parms to subnet pool cmds 2016-04-20 20:12:02 -05:00
bug-1544587-ec3ca453c1340b4e.yaml Subnet Pool: Add "subnet pool delete" command 2016-02-18 08:53:39 +08:00
bug-1544589-b9f669ef71aa5e57.yaml Subnet Pool: Add "subnet pool list" command 2016-02-19 11:00:33 +08:00
bug-1544590-8cf42954e28c2f42.yaml Subnet Pool: Add "subnet pool show" command 2016-02-19 11:05:28 +08:00
bug-1545537-7a66219d263bb1e5.yaml Add external network options to osc network set 2016-04-15 00:28:09 +00:00
bug-1545537-12bbf01d2280dd2f.yaml Add provider network options to osc network set 2016-04-19 11:18:13 +09:00
bug-1545609-bdc1efc17214463b.yaml Fixed command list 2016-03-09 16:00:39 +00:00
bug-1546065-41d09ffbd8606513.yaml Make SetAggregate inherit from cliff.Command 2016-02-27 03:50:47 +08:00
bug-1554877-7f8479791eab45b7.yaml Clean up for next release 2016-04-18 14:19:27 -05:00
bug-1554889-32ba8d4bfb0f5f3d.yaml Clean up for next release 2016-04-18 14:19:27 -05:00
bug-1556929-edd78cded88ecdc9.yaml Clean up for next release 2016-04-18 14:19:27 -05:00
bug-1559866-733988f5dd5b07bb.yaml Clean up for next release 2016-04-18 14:19:27 -05:00
bug-1560157-bce572f58b43efa1.yaml Fix SSL/TLS verification for network commands 2016-04-08 09:33:33 -05:00
bug-1565112-e0cea9bfbcab954f.yaml Clean up for next release 2016-04-18 14:19:27 -05:00
bug-1569480-c52e330548bfbd78.yaml Fix prefixes output for subnet pool list 2016-04-12 12:42:13 -05:00
bug-1571812-49cdce4df5f3d481.yaml Rename --profile to --os-profile 2016-04-19 07:50:42 -05:00
bug-1572733-874b37a7fa8292d0.yaml Support quota show for current project 2016-04-21 11:33:24 -05:00
bug-1575478-5a0a923c3a32f96a.yaml Make "flavor show" command to show a private flavor properly 2016-05-02 16:47:53 +08:00
bug-1575624-87957ff60ad661a6.yaml Fix error in flavor set/unset command 2016-04-28 19:59:53 +08:00
list_role_assignment_names-0db89f50259d4be2.yaml Return names in list role assignments 2016-01-27 18:13:32 +00:00
make-snapshot-and-backup-name-optional-01971d33640ef1c8.yaml Make snapshot and backup name optional 2016-04-06 23:25:38 +03:00
no-project-usage-list-e88eb49aa2e96cf7.yaml Fix formatting in release 2.0.0 notes 2016-02-05 16:25:01 -06:00
recursive-container-delete-983361aa9c35ffed.yaml Add release note for recursive delete 2016-02-07 01:22:32 +00:00
router-port-add-0afe7392c080bcb8.yaml Add "router add port" to osc 2016-03-21 02:07:21 +00:00
router-remove-port-058078c93819b0f4.yaml Add "router remove port" to osc 2016-03-21 02:08:16 +00:00
router-subnet-469d095ae0bac884.yaml Add Subnet add/remove support to router 2016-03-22 01:55:19 +00:00
server-changes-3962541b6ebdbbd8.yaml Fix formatting in release 2.0.0 notes 2016-02-05 16:25:01 -06:00
subnet-set-bbc26ecc16929302.yaml Subnet: Add "subnet set" command using SDK 2016-03-24 02:21:40 +00:00
volume_service-5e352a71dfbc828d.yaml Support for volume service list 2016-04-25 17:42:12 +00:00