openstack/python-solumclient
Code Issues Proposed changes

Replace assertTrue(isinstance()) with assertIsInstance()

Browse Source 
Some of tests use different method of assertTrue(isinstance(A, B)) or
assertEqual(type(A), B). The correct way is to use assertIsInstance(A,
B) provided by testtools.
Closes-Bug: #1268480

Change-Id: I0a318979a926b630e534fe6c76d9188640cf7ce0
This commit is contained in:
malei
2015-10-18 08:00:09 +08:00
parent 1e75e3778c
commit e9fc58c7ca
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
solumclient/tests/common/test_exc.py
View File

@@ -45,7 +45,7 @@ class ExceptionTest(base.TestCase):
method, method,
url url
) )
self.assertTrue(isinstance(ex, exceptions.HttpError)) self.assertIsInstance(ex, exceptions.HttpError)
self.assertEqual(json_data["faultstring"], ex.message) self.assertEqual(json_data["faultstring"], ex.message)
self.assertEqual(json_data["debuginfo"], ex.details) self.assertEqual(json_data["debuginfo"], ex.details)
self.assertEqual(method, ex.method) self.assertEqual(method, ex.method)