From fd531abac3f0857a12aed1f527b22bcb5ae8a93c Mon Sep 17 00:00:00 2001 From: zhurong Date: Wed, 2 Jan 2019 14:20:18 +0800 Subject: [PATCH] Fix some pep8 error Change-Id: I805bed4b74a9ea94d38fc9c197920d4fb0377139 --- solumclient/common/apiclient/fake_client.py | 8 ++++---- solumclient/common/auth.py | 2 +- solumclient/tests/v1/test_plan.py | 2 +- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/solumclient/common/apiclient/fake_client.py b/solumclient/common/apiclient/fake_client.py index 54227ca..d05bb34 100644 --- a/solumclient/common/apiclient/fake_client.py +++ b/solumclient/common/apiclient/fake_client.py @@ -91,8 +91,8 @@ class FakeHTTPClient(client.HTTPClient): """Assert than an API method was just called.""" expected = (method, url) called = self.callstack[pos][0:2] - assert (self.callstack, - "Expected %s %s but no calls were made." % expected) + assert self.callstack, \ + "Expected %s %s but no calls were made." % expected assert expected == called, 'Expected %s %s; got %s %s' % ( expected + called) @@ -106,8 +106,8 @@ class FakeHTTPClient(client.HTTPClient): """Assert than an API method was called anytime in the test.""" expected = (method, url) - assert (self.callstack, - "Expected %s %s but no calls were made." % expected) + assert self.callstack, \ + "Expected %s %s but no calls were made." % expected found = False entry = None diff --git a/solumclient/common/auth.py b/solumclient/common/auth.py index 699db72..819d956 100644 --- a/solumclient/common/auth.py +++ b/solumclient/common/auth.py @@ -186,7 +186,7 @@ class KeystoneAuthPlugin(auth.BaseAuthPlugin): # retrieve session ks_session = _get_keystone_session(**ks_kwargs) - token = lambda: ks_session.get_token() + token = ks_session.get_token() endpoint = (self.opts.get('endpoint') or _get_endpoint(ks_session, **ks_kwargs)) self.opts['token'] = token diff --git a/solumclient/tests/v1/test_plan.py b/solumclient/tests/v1/test_plan.py index bf1249a..8bab3a6 100644 --- a/solumclient/tests/v1/test_plan.py +++ b/solumclient/tests/v1/test_plan.py @@ -172,7 +172,7 @@ class PlanManagerTest(base.TestCase): def test_plan_create_post_success(self): api_client = mock.MagicMock() dummy_data = 'version: 1\nname: ex_plan1\ndescription: dsc1.' - response = lambda: None + response = mock.MagicMock() setattr(response, 'content', dummy_data) api_client.post.return_value = response try: