openstack/python-swiftclient
Code Issues Proposed changes

don't use mutable defaults in kwargs

Browse Source 
Change-Id: I3ae71259ccc49a5d8a852388784c3dfd577df50a
This commit is contained in:
John Dickinson 2014-03-30 10:08:09 -07:00
parent 4f3d6e7f3a
commit 1f0dd002db
1 changed files with 4 additions and 2 deletions

6
swiftclient/client.py

@ -187,8 +187,10 @@ class HTTPConnection:
""" Final wrapper before requests call, to be patched in tests """ """ Final wrapper before requests call, to be patched in tests """
return requests.request(*arg, **kwarg) return requests.request(*arg, **kwarg)
def request(self, method, full_path, data=None, headers={}, files=None): def request(self, method, full_path, data=None, headers=None, files=None):
""" Encode url and header, then call requests.request """ """ Encode url and header, then call requests.request """
if headers is None:
headers = {}
headers = dict((encode_utf8(x.lower()), encode_utf8(y)) for x, y in headers = dict((encode_utf8(x.lower()), encode_utf8(y)) for x, y in
headers.items()) headers.items())
# set a default User-Agent header if it wasn't passed in # set a default User-Agent header if it wasn't passed in
@ -202,7 +204,7 @@ class HTTPConnection:
files=files, **self.requests_args) files=files, **self.requests_args)
return self.resp return self.resp
def putrequest(self, full_path, data=None, headers={}, files=None): def putrequest(self, full_path, data=None, headers=None, files=None):
""" """
Use python-requests files upload Use python-requests files upload