openstack/python-swiftclient
Code Issues Proposed changes

Do not create an empty directory 'pseudo/'

Browse Source 
This is a fix-up for the commit 3d56b65c. The code change was good,
but the additional test had a side effect of creating an empty
directory "pseudo/". Fix this by mocking-out mkdirs().

Change-Id: Iead55e72d8a75d96bde0a7491aca12bbdcc269cf
This commit is contained in:
Pete Zaitcev
2014-08-18 16:51:01 -06:00
parent eedb0d4ab5
commit 309437bb52
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
tests/unit/test_shell.py
View File

@@ -173,8 +173,9 @@ class TestShell(unittest.TestCase):
mock.call(' 0')] mock.call(' 0')]
mock_print.assert_has_calls(calls) mock_print.assert_has_calls(calls)
@mock.patch('swiftclient.shell.makedirs')
@mock.patch('swiftclient.shell.Connection') @mock.patch('swiftclient.shell.Connection')
def test_download(self, connection): def test_download(self, connection, makedirs):
connection.return_value.get_object.return_value = [ connection.return_value.get_object.return_value = [
{'content-type': 'text/plain', {'content-type': 'text/plain',
'etag': 'd41d8cd98f00b204e9800998ecf8427e'}, 'etag': 'd41d8cd98f00b204e9800998ecf8427e'},