openstack
/
python-swiftclient
Code Issues Proposed changes

Use a valid default for auth_version 

The valid set of values for auth_version does not include
values starting with the 'v'.

In this particular function, the auth_version variable is
only used for comparisons with v3. So, the code worked
correctly. However, let's clean this up in order to reduce
review confusion and defuse possible future landmine in case
of code changes.

Change-Id: I671016d7992a1922b786b4eb8876b3fbb2532e15
This commit is contained in:
Pete Zaitcev 2018-05-04 13:31:03 -05:00
parent 5ed910cd32
commit 7a13754eeb
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
swiftclient/client.py
View File

@ -565,7 +565,7 @@ def get_auth_keystone(auth_url, user, key, os_options, **kwargs):
# Legacy default if not set
if auth_version is None:
auth_version = 'v2.0'
auth_version = '2'
ksclient, exceptions = _import_keystone_client(auth_version)
try: