openstack/python-swiftclient
Code Issues Proposed changes

Strip leading/trailing whitespace from headers

Browse Source 
New versions of requests will raise an InvalidHeader error otherwise.

Change-Id: Idf3bcd8ac359bdda9a847bf99a78988943374134
Closes-Bug: #1614280
Closes-Bug: #1613814
This commit is contained in:
Tim Burke 2016-08-17 16:01:23 -07:00 committed by Tim Burke
parent b1539d9c0f
commit 8fbe118cea
2 changed files with 2 additions and 2 deletions
swiftclient
service.py
tests/unit
test_service.py

2
swiftclient/service.py

@ -280,7 +280,7 @@ def split_headers(options, prefix=''):
for item in options:
split_item = item.split(':', 1)
if len(split_item) == 2:
headers[(prefix + split_item[0]).title()] = split_item[1]
headers[(prefix + split_item[0]).title()] = split_item[1].strip()
else:
raise SwiftError(
"Metadata parameter %s must contain a ':'.\n%s"

2
tests/unit/test_service.py

@ -496,7 +496,7 @@ class TestServiceUtils(unittest.TestCase):
self.assertEqual(opt_c['key'], 'key')
def test_split_headers(self):
mock_headers = ['color:blue', 'size:large']
mock_headers = ['color:blue', 'SIZE: large']
expected = {'Color': 'blue', 'Size': 'large'}
actual = swiftclient.service.split_headers(mock_headers)