openstack/python-swiftclient
Code Issues Proposed changes

Merge "Make proper functions instead of assigning lambdas"

Browse Source
This commit is contained in:
Zuul 2019-03-30 03:34:49 +00:00 committed by Gerrit Code Review
commit b62d378836
3 changed files with 7 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
swiftclient/client.py
View File

@ -1885,7 +1885,9 @@ class Connection(object):
reset = getattr(contents, 'reset', None) reset = getattr(contents, 'reset', None)
if tell and seek: if tell and seek:
orig_pos = tell() orig_pos = tell()
reset_func = lambda *a, **k: seek(orig_pos)
def reset_func(*a, **kw):
seek(orig_pos)
elif reset: elif reset:
reset_func = reset reset_func = reset
return self._retry(reset_func, put_object, container, obj, contents, return self._retry(reset_func, put_object, container, obj, contents,

4
swiftclient/service.py
View File

@ -451,7 +451,9 @@ class SwiftService(object):
**_default_local_options **_default_local_options
) )
process_options(self._options) process_options(self._options)
create_connection = lambda: get_conn(self._options)
def create_connection():
return get_conn(self._options)
self.thread_manager = MultiThreadingManager( self.thread_manager = MultiThreadingManager(
create_connection, create_connection,
segment_threads=self._options['segment_threads'], segment_threads=self._options['segment_threads'],

2
tox.ini
View File

@ -77,7 +77,7 @@ commands=
# H403: multi line docstrings should end on a new line # H403: multi line docstrings should end on a new line
# H404: multi line docstring should start without a leading new line # H404: multi line docstring should start without a leading new line
# H405: multi line docstring summary not separated with an empty line # H405: multi line docstring summary not separated with an empty line
ignore = E731,H101,H301,H306,H401,H403,H404,H405 ignore = H101,H301,H306,H401,H403,H404,H405
show-source = True show-source = True
exclude = .venv,.tox,dist,doc,*egg exclude = .venv,.tox,dist,doc,*egg