openstack/python-swiftclient
Code Issues Proposed changes

Get rid of FakeConn cruft

Browse Source 
Presumably, this was left over from before the httplib -> requests
transition?

Change-Id: I7f505514070bf9d8fefda77203bee78f0a5dd71d
This commit is contained in:
Tim Burke 2016-01-18 18:34:47 -08:00
parent 64c2c2eaaa
commit dcdd715215
1 changed files with 0 additions and 18 deletions

18
tests/unit/utils.py

@ -100,27 +100,11 @@ def fake_http_connect(*code_iter, **kwargs):
self._is_closed = True self._is_closed = True
self.headers = headers or {} self.headers = headers or {}
def connect(self):
self._is_closed = False
def close(self):
self._is_closed = True
def isclosed(self):
return self._is_closed
def getresponse(self): def getresponse(self):
if kwargs.get('raise_exc'): if kwargs.get('raise_exc'):
raise Exception('test') raise Exception('test')
return self return self
def getexpect(self):
if self.status == -2:
raise RequestException()
if self.status == -3:
return FakeConn(507)
return FakeConn(100)
def getheaders(self): def getheaders(self):
if self.headers: if self.headers:
return self.headers.items() return self.headers.items()
@ -199,7 +183,6 @@ def fake_http_connect(*code_iter, **kwargs):
timestamp=timestamp) timestamp=timestamp)
if fake_conn.status <= 0: if fake_conn.status <= 0:
raise RequestException() raise RequestException()
fake_conn.connect()
return fake_conn return fake_conn
connect.code_iter = code_iter connect.code_iter = code_iter
@ -250,7 +233,6 @@ class MockHttpTest(testtools.TestCase):
self.request_log.append((parsed, method, url, args, self.request_log.append((parsed, method, url, args,
kwargs, conn.resp)) kwargs, conn.resp))
conn.host = conn.resp.host conn.host = conn.resp.host
conn.isclosed = conn.resp.isclosed
conn.resp.has_been_read = False conn.resp.has_been_read = False
_orig_read = conn.resp.read _orig_read = conn.resp.read