openstack/python-swiftclient
Code Issues Proposed changes

Remove unnecessary calls to parse_header_string().

Browse Source 
Since we define the getheader() method on the response from
HTTPConnection, we don't have to call parse_header_string, as the values
will already be converted properly.

Change-Id: Ia81e8674b828b3ff1f014454126b469e41adfc23
This commit is contained in:
Timur Alperovich 2018-07-24 11:53:25 -07:00
parent 6872b95560
commit e28b12a1f2
1 changed files with 2 additions and 8 deletions

10
swiftclient/client.py

@ -529,10 +529,8 @@ def get_auth_1_0(url, user, key, snet, **kwargs):
parsed[1] = 'snet-' + netloc parsed[1] = 'snet-' + netloc
url = urlunparse(parsed) url = urlunparse(parsed)
auth_token = resp.getheader('x-auth-token') token = resp.getheader('x-storage-token', resp.getheader('x-auth-token'))
if auth_token is not None: return url, token
auth_token = parse_header_string(auth_token)
return url, resp.getheader('x-storage-token', auth_token)
def get_keystoneclient_2_0(auth_url, user, key, os_options, **kwargs): def get_keystoneclient_2_0(auth_url, user, key, os_options, **kwargs):
@ -712,14 +710,10 @@ def get_auth(auth_url, user, key, **kwargs):
raise ClientException('Unknown auth_version %s specified and no ' raise ClientException('Unknown auth_version %s specified and no '
'session found.' % auth_version) 'session found.' % auth_version)
if token is not None:
token = parse_header_string(token)
# Override storage url, if necessary # Override storage url, if necessary
if os_options.get('object_storage_url'): if os_options.get('object_storage_url'):
return os_options['object_storage_url'], token return os_options['object_storage_url'], token
else: else:
if storage_url is not None:
return parse_header_string(storage_url), token
return storage_url, token return storage_url, token