openstack/python-swiftclient
Code Issues Proposed changes

Suppress InsecureRequestWarning when using --insecure

Browse Source 
The user already knows this is insecure, there's no point in bringing it
up again and again.

See also: https://github.com/kennethreitz/requests/issues/2214

Change-Id: I7991b2e568407269f84138bc03711147ed080c9c
This commit is contained in:
Tim Burke
2016-06-01 16:45:54 -07:00
parent f9d0657e70
commit ff505d72cd
2 changed files with 23 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
swiftclient/shell.py
View File

@@ -1524,6 +1524,11 @@ Examples:
with OutputManager() as output: with OutputManager() as output:
parser.usage = globals()['st_%s_help' % args[0]] parser.usage = globals()['st_%s_help' % args[0]]
if options['insecure']:
import requests
from requests.packages.urllib3.exceptions import \
InsecureRequestWarning
requests.packages.urllib3.disable_warnings(InsecureRequestWarning)
try: try:
globals()['st_%s' % args[0]](parser, argv[1:], output) globals()['st_%s' % args[0]](parser, argv[1:], output)
except ClientException as err: except ClientException as err:

16
tests/unit/test_shell.py
View File

@@ -23,7 +23,7 @@ import tempfile
import unittest import unittest
import textwrap import textwrap
from requests.packages.urllib3.exceptions import InsecureRequestWarning
import six import six
import swiftclient import swiftclient
@@ -1899,9 +1899,11 @@ class TestKeystoneOptions(MockHttpTest):
auth_token=token) auth_token=token)
with mock.patch('swiftclient.client._import_keystone_client', with mock.patch('swiftclient.client._import_keystone_client',
_make_fake_import_keystone_client(fake_ks)): _make_fake_import_keystone_client(fake_ks)), \
with mock.patch('swiftclient.client.http_connection', fake_conn): mock.patch('swiftclient.client.http_connection', fake_conn), \
with mock.patch.dict(os.environ, env, clear=True): mock.patch.dict(os.environ, env, clear=True), \
mock.patch('requests.packages.urllib3.disable_warnings') as \
mock_disable_warnings:
try: try:
swiftclient.shell.main(args) swiftclient.shell.main(args)
except SystemExit as e: except SystemExit as e:
@@ -1909,6 +1911,12 @@ class TestKeystoneOptions(MockHttpTest):
except SwiftError as err: except SwiftError as err:
self.fail('Unexpected SwiftError: %s' % err) self.fail('Unexpected SwiftError: %s' % err)
if 'insecure' in flags:
self.assertEqual([mock.call(InsecureRequestWarning)],
mock_disable_warnings.mock_calls)
else:
self.assertEqual([], mock_disable_warnings.mock_calls)
if no_auth: if no_auth:
# check that keystone client was not used and terminate tests # check that keystone client was not used and terminate tests
self.assertIsNone(getattr(fake_ks, 'auth_version')) self.assertIsNone(getattr(fake_ks, 'auth_version'))