From 6325127c03fd1b2748411b1e4e787d4f8bcba060 Mon Sep 17 00:00:00 2001 From: Javier Pena Date: Thu, 5 Aug 2021 09:40:19 +0200 Subject: [PATCH] Remove use of testtools.helpers.safe_hasattr The testtools package removed safe_hasattr in version 2.5.0 [1]. Since it is only used in two unit tests, let's replace it with the built-in hasattr. [1] - https://github.com/testing-cabal/testtools/blob/2.5.0/NEWS#L31-L34 Change-Id: I57be2d06efe8913805069150bd3f884322a78a42 --- tackerclient/tests/unit/test_command_meta.py | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/tackerclient/tests/unit/test_command_meta.py b/tackerclient/tests/unit/test_command_meta.py index 5ae763a6..e43370bd 100644 --- a/tackerclient/tests/unit/test_command_meta.py +++ b/tackerclient/tests/unit/test_command_meta.py @@ -17,7 +17,6 @@ import logging import testtools -from testtools import helpers from tackerclient.tacker import v1_0 as tackerV10 @@ -27,7 +26,7 @@ class TestCommandMeta(testtools.TestCase): class FakeCommand(tackerV10.TackerCommand): pass - self.assertTrue(helpers.safe_hasattr(FakeCommand, 'log')) + self.assertTrue(hasattr(FakeCommand, 'log')) self.assertIsInstance(FakeCommand.log, logging.getLoggerClass()) self.assertEqual(FakeCommand.log.name, __name__ + ".FakeCommand") @@ -35,5 +34,5 @@ class TestCommandMeta(testtools.TestCase): class FakeCommand(tackerV10.TackerCommand): log = None - self.assertTrue(helpers.safe_hasattr(FakeCommand, 'log')) + self.assertTrue(hasattr(FakeCommand, 'log')) self.assertIsNone(FakeCommand.log)