openstack/python-tackerclient
Code Issues Proposed changes

Correct YAML load warning

Browse Source 
The use of `yaml.load` without Loader is deprecated and
considered unsafe.

The warning notice:
/opt/stack/python-tackerclient/tackerclient/tacker/v1_0/nfvo/vim.py:
YAMLLoadWarning: calling yaml.load() without Loader=... is deprecated,
as the default Loader is unsafe.
Please read https://msg.pyyaml.org/load for full details.
config_param = yaml.load(config_yaml)

This change adds (Loader=yaml.SafeLoader) to remove the warning.

Change-Id: Idc77d855b41801777d57cfe92d1c448b6e72feaa
This commit is contained in:
Manpreet Kaur
2021-07-02 20:36:29 +05:30
parent ce07d93715
commit 94e28fc28f
2 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
tackerclient/osc/v1/nfvo/vim.py
View File

@@ -230,7 +230,8 @@ class UpdateVIM(command.ShowOne):
with open(parsed_args.config_file) as f: with open(parsed_args.config_file) as f:
config_yaml = f.read() config_yaml = f.read()
try: try:
config_param = yaml.load(config_yaml) config_param = yaml.load(config_yaml,
Loader=yaml.SafeLoader)
except yaml.YAMLError as e: except yaml.YAMLError as e:
raise exceptions.InvalidInput(reason=e) raise exceptions.InvalidInput(reason=e)
vim_obj = body[_VIM] vim_obj = body[_VIM]

3
tackerclient/tacker/v1_0/nfvo/vim.py
View File

@@ -117,7 +117,8 @@ class UpdateVIM(tackerV10.UpdateCommand):
with open(parsed_args.config_file) as f: with open(parsed_args.config_file) as f:
config_yaml = f.read() config_yaml = f.read()
try: try:
config_param = yaml.load(config_yaml) config_param = yaml.load(config_yaml,
Loader=yaml.SafeLoader)
except yaml.YAMLError as e: except yaml.YAMLError as e:
raise exceptions.InvalidInput(reason=e) raise exceptions.InvalidInput(reason=e)
vim_obj = body[self.resource] vim_obj = body[self.resource]