openstack/python-tackerclient
Code Issues Proposed changes

vnfd-delete gives ambiguous success message

Browse Source 
When a single vnfd is deleted, the following success message is delivered.

$> tacker vnfd-delete cirros-vnfd-multi-vdu

All vnfd(s) deleted successfully

The above success message has to modified to
" All specified %(resource)s(s) %(msg)s successfully? "

Change-Id: I48443622b718a1d6a1476f53c6378b67ce0d82e4
Closes-Bug: #1672302
This commit is contained in:
Trinath Somanchi
2017-03-13 15:30:24 +05:30
parent 205c882646
commit c80b0c7133
2 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
tackerclient/tacker/v1_0/__init__.py
View File

@@ -560,7 +560,7 @@ class DeleteCommand(TackerCommand):
msg += err_msg msg += err_msg
raise exceptions.CommandError(msg) raise exceptions.CommandError(msg)
else: else:
print((_('All %(resource)s(s) %(msg)s successfully') print((_('All specified %(resource)s(s) %(msg)s successfully')
% {'msg': self.deleted_msg.get(self.resource, 'deleted'), % {'msg': self.deleted_msg.get(self.resource, 'deleted'),
'resource': self.resource})) 'resource': self.resource}))
return return

2
tackerclient/tests/unit/test_cli10.py
View File

@@ -617,7 +617,7 @@ class CLITestV10Base(testtools.TestCase):
headers=test_utils.ContainsKeyValue('X-Auth-Token', TOKEN)) headers=test_utils.ContainsKeyValue('X-Auth-Token', TOKEN))
mock_get.assert_called_once_with() mock_get.assert_called_once_with()
_str = self.fake_stdout.make_string() _str = self.fake_stdout.make_string()
msg = 'All %(resource)s(s) %(msg)s successfully\n' % { msg = 'All specified %(resource)s(s) %(msg)s successfully\n' % {
'msg': deleted_msg.get(resource, 'deleted'), 'msg': deleted_msg.get(resource, 'deleted'),
'resource': resource} 'resource': resource}
self.assertEqual(msg, _str) self.assertEqual(msg, _str)