1.As mentioned in [1], we should avoid usingg
six.iteritems to achieve iterators. We can
use dict.items instead, as it will return
iterators in PY3 as well. And dict.items/keys
will more readable. 2.In py2, the performance
about list should be negligible, see the link [2].
[1] https://wiki.openstack.org/wiki/Python3
[2] http://lists.openstack.org/pipermail/openstack-dev/2015-June/066391.html
Change-Id: I988ff08fe1d6bc52c4a601641c564db7881accf4
Make auth_creds display the user specified credentials
which are project_name and username. Normally
vim configuration yaml file has no project_id and user_id
Change-Id: I987ad7bda04b0a161c56284f77964063490a18e0
Closes-Bug: #1629169
use mock instead of mox
Co-Authored-By: Trinath Somanchi <trinanth.somachi@nxp.com>
Change-Id: I9e5327a4e4e6cba220670b096f718e7343fd43dc
Closes-Bug: #1572706
it caused No handlers could be found for logger "tackerclient.shell"
This reverts commit af2f0f031f12ebdbfe17f2abddc1794d1396fb8c.
Change-Id: I8556dbf7ea45a268daa900e00c5334f11cd106d0
tackerclient is currently using python logging module to
implement logging functionality.
This patch made a switch to oslo.log(logging for openstack projects)
Reference:-
http://docs.openstack.org/developer/oslo.log
Change-Id: Iecab180e605c788bb820c7a628781abf9a4918ea
Closes-Bug: #1656167
When a single vnfd is deleted, the following success message is delivered.
$> tacker vnfd-delete cirros-vnfd-multi-vdu
All vnfd(s) deleted successfully
The above success message has to modified to
" All specified %(resource)s(s) %(msg)s successfully? "
Change-Id: I48443622b718a1d6a1476f53c6378b67ce0d82e4
Closes-Bug: #1672302
Starting from Ocata tacker payloads will only accept
YAML dict for config and param payload values. Hence
remove the warning when something other than YAML dict
is received by the client. Such a CLI input is no longer
make sense. So, starting Ocata deprecate all direct
YAML input and remove it in Pike.
Change-Id: I03f3ac405e92d7e9fa69fd2b2761c243456fd7e8
Partial-Bug: 1656416
Allows creating VNF from the VNFD template directly without the need of
VNFD being stored in Tacker VNFD catalog.
Change-Id: I719237dd04dd7fe13fb7e7964402d7074679b2d6
Implements: blueprint vnf-inline-template
From Mitaka version, Tacker supports TOSCA based VNFD templates.
Legacy templates were deprecated in newton. Server side already
commited in https://review.openstack.org/#/c/382786/.
Removing related checks in client side now.
Implements: blueprint deprecate-legacy-template-dsl
Change-Id: I60b683c6d63b6976d438ff6130d16ddbf0656940
events-list command's help text for some options does not follow common
format. Also, *-events-list commands have similar issues. This patch
fixes help texts for these commands to make them clearer for users.
Change-Id: Icd85d13fee437bf0f83979eb6625377b38ce39ad
Closes-bug: #1628769
Unit tests are not testing the behavior of command-line client
code properly since mox was replaced with mock in [1].
[1] https://review.openstack.org/#/c/313165/
assert_called_once_with() should be called after the target
call of the patched method.
Change-Id: I99873e9cb1d75d1fa2e41c02b9f87dfa4f9ef1f7
Partial-Bug: #1572706
For logging the exception message: e.message has been
deprecated. The preferred way is to call str(e).
more details:
https://www.python.org/dev/peps/pep-0352/
Change-Id: Ic22fbd37376843f714d2c1669d2cdc25a3569225
This patch removes passing infra and mgmt driver as part of VNFD body from
client and API.
Change-Id: I4684e69b8993e6c35503317503dd73e2c13f44dd
Partial-Bug: #1630936
Help msg in tacker project should support oslo.i18n. But
tests directory faces developer, So it needn't support oslo.i18n.
Co-Authored-By: ShuYingya<yingya.shu@easystack.cn>
Change-Id: I60106b106cfd77b46663ff35a2735cfa5ea158f0
In Python 3 __ne__ by default delegates to __eq__ and inverts the
result, but in Python 2 they urge you to define __ne__ when you define
__eq__ for it to work properly [1]. There are no implied relationships
among the comparison operators. The truth of x==y does not imply that
x!=y is false. Accordingly, when defining __eq__(), one should also
define __ne__() so that the operators will behave as expected.
[1]https://docs.python.org/2/reference/datamodel.html#object.__ne__
Change-Id: I6adceadb6e3749e34cf847654f28a3b6eea832fd
Tacker CLI does not support updating name and description of VIM.
This patch introduces --name and --description options to vim-update.
Also, existing --is-default option's behavior can be improved.
Currently is_default attribute will be set to False when --is-default
is ommited, and will be set to True when --is-default is specified.
So even a user, who wants to update attributes other than is_default,
needs to be aware of current is_default setting. This patch will make
the behavior of --is-default option clearer like below:
1.When --is-default True is specified, it'll be set to True.
2.When --is-default False is specified, it'll be set to False.
3.When --is-default is ommited, it will stay as-is.
In addition, --config-file should be a required option because both
server and client expect it to be given when updating VIM.
Change-Id: Ic19fb6b0efb48bc3486f94836be4f2ff35f8c84b
Partial-Bug: 1637360
Directive "from __future__ import print_function" is not an actual
import, but it enables print statement in py2 to behave like a real
function in py3.
This allows us to use print() function in py2/py3 compatible way.
This reverts commit 9910cbc746380dba2c8dc5f89120f0f48a74ced7.
Change-Id: Ibdef82f0da42e815fd6c9ec632d0fd36c272b094
remove _get_attr_metadata monkey_patch since it is for XML test.
remove iterkeys() call which is not py3.x compatible.
Change-Id: I46df0a3748f470521553793111a21eea72bd7663
Closes-bug: 1632714
Refactoring unit tests to use mock instead of mox
other mox usages by not run test cases will be dealt with
later.
Co-Authored-By: gong yong sheng <gong.yongsheng@99cloud.net>
Co-Authored-By: Trevor McCasland <TM2086@att.com>
Change-Id: I7e42494b96f1e54f5f04534d3b453422ea1bf4ef
Partial-Bug: #1572706
Here cString dose not exist in py3.x. This patch is used to
fix py34 gate errors.
Partial-Bug: #1612071
Change-Id: I0a36777cba8c4602c16be771956d4cd26f7e979f
