e8debf8d55
It is a common pattern to add
class XXXCommand(NeutronCommand):
log = logging.getLogger(__name__ + '.<command name>').
So introduce a metaclass to do that automatically in order to simplify
the code a bit.
Change-Id: I7febdcd806eb2da51781a5866cc5fac5422b1721
44 lines
1.5 KiB
Python
44 lines
1.5 KiB
Python
# Copyright 2013 Intel
|
|
# Copyright 2013 Isaku Yamahata <isaku.yamahata at intel com>
|
|
# <isaku.yamahata at gmail com>
|
|
# All Rights Reserved.
|
|
#
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License"); you may
|
|
# not use this file except in compliance with the License. You may obtain
|
|
# a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
|
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
|
# License for the specific language governing permissions and limitations
|
|
# under the License.
|
|
#
|
|
# @author: Isaku Yamahata, Intel
|
|
|
|
import logging
|
|
|
|
import testtools
|
|
from testtools import helpers
|
|
|
|
from neutronclient.neutron import v2_0 as neutronV20
|
|
|
|
|
|
class TestCommandMeta(testtools.TestCase):
|
|
def test_neutron_command_meta_defines_log(self):
|
|
class FakeCommand(neutronV20.NeutronCommand):
|
|
pass
|
|
|
|
self.assertTrue(helpers.safe_hasattr(FakeCommand, 'log'))
|
|
self.assertIsInstance(FakeCommand.log, logging.getLoggerClass())
|
|
self.assertEqual(FakeCommand.log.name, __name__ + ".FakeCommand")
|
|
|
|
def test_neutron_command_log_defined_explicitly(self):
|
|
class FakeCommand(neutronV20.NeutronCommand):
|
|
log = None
|
|
|
|
self.assertTrue(helpers.safe_hasattr(FakeCommand, 'log'))
|
|
self.assertIsNone(FakeCommand.log)
|