b45904f7a1
Tacker CLI does not support updating name and description of VIM. This patch introduces --name and --description options to vim-update. Also, existing --is-default option's behavior can be improved. Currently is_default attribute will be set to False when --is-default is ommited, and will be set to True when --is-default is specified. So even a user, who wants to update attributes other than is_default, needs to be aware of current is_default setting. This patch will make the behavior of --is-default option clearer like below: 1.When --is-default True is specified, it'll be set to True. 2.When --is-default False is specified, it'll be set to False. 3.When --is-default is ommited, it will stay as-is. In addition, --config-file should be a required option because both server and client expect it to be given when updating VIM. Change-Id: Ic19fb6b0efb48bc3486f94836be4f2ff35f8c84b Partial-Bug: 1637360
130 lines
4.5 KiB
Python
130 lines
4.5 KiB
Python
# Copyright 2016 Brocade Communications Systems Inc
|
|
# All Rights Reserved.
|
|
#
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License"); you may
|
|
# not use this file except in compliance with the License. You may obtain
|
|
# a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
|
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
|
# License for the specific language governing permissions and limitations
|
|
# under the License.
|
|
|
|
import yaml
|
|
|
|
from oslo_utils import strutils
|
|
|
|
from tackerclient.common import exceptions
|
|
from tackerclient.tacker import v1_0 as tackerV10
|
|
from tackerclient.tacker.v1_0.nfvo import vim_utils
|
|
|
|
_VIM = "vim"
|
|
|
|
|
|
class ListVIM(tackerV10.ListCommand):
|
|
"""List VIMs that belong to a given tenant."""
|
|
|
|
resource = _VIM
|
|
list_columns = ['id', 'tenant_id', 'name', 'type', 'description',
|
|
'auth_url', 'placement_attr', 'auth_cred', 'status']
|
|
|
|
|
|
class ShowVIM(tackerV10.ShowCommand):
|
|
"""Show information of a given VIM."""
|
|
|
|
resource = _VIM
|
|
|
|
|
|
class CreateVIM(tackerV10.CreateCommand):
|
|
"""Create a VIM."""
|
|
|
|
resource = _VIM
|
|
|
|
def add_known_arguments(self, parser):
|
|
parser.add_argument(
|
|
'--config-file',
|
|
required=True,
|
|
help='Specify VIM specific config parameters in a file')
|
|
parser.add_argument(
|
|
'name', metavar='NAME',
|
|
help='Set a name for the VIM')
|
|
parser.add_argument(
|
|
'--description',
|
|
help='Set a description for the VIM')
|
|
parser.add_argument(
|
|
'--is-default',
|
|
action='store_true',
|
|
default=False,
|
|
help='Set as default VIM')
|
|
|
|
def args2body(self, parsed_args):
|
|
body = {self.resource: {}}
|
|
if parsed_args.config_file:
|
|
with open(parsed_args.config_file) as f:
|
|
vim_config = f.read()
|
|
config_param = yaml.load(vim_config, Loader=yaml.SafeLoader)
|
|
vim_obj = body[self.resource]
|
|
try:
|
|
auth_url = config_param.pop('auth_url')
|
|
except KeyError:
|
|
raise exceptions.TackerClientException(message='Auth URL must be '
|
|
'specified',
|
|
status_code=404)
|
|
vim_obj['auth_url'] = vim_utils.validate_auth_url(auth_url).geturl()
|
|
vim_obj['type'] = config_param.pop('type', 'openstack')
|
|
vim_utils.args2body_vim(config_param, vim_obj)
|
|
tackerV10.update_dict(parsed_args, body[self.resource],
|
|
['tenant_id', 'name', 'description',
|
|
'is_default'])
|
|
return body
|
|
|
|
|
|
class UpdateVIM(tackerV10.UpdateCommand):
|
|
"""Update a given VIM."""
|
|
|
|
resource = _VIM
|
|
|
|
def add_known_arguments(self, parser):
|
|
parser.add_argument(
|
|
'--config-file',
|
|
required=True,
|
|
help='Specify VIM specific config parameters in a file')
|
|
parser.add_argument(
|
|
'--name',
|
|
help='New name for the VIM')
|
|
parser.add_argument(
|
|
'--description',
|
|
help='New description for the VIM')
|
|
parser.add_argument(
|
|
'--is-default',
|
|
type=strutils.bool_from_string,
|
|
metavar='{True,False}',
|
|
help='Indicate whether the VIM is used as default')
|
|
|
|
def args2body(self, parsed_args):
|
|
body = {self.resource: {}}
|
|
# config arg passed as data overrides config yaml when both args passed
|
|
if parsed_args.config_file:
|
|
with open(parsed_args.config_file) as f:
|
|
config_yaml = f.read()
|
|
config_param = yaml.load(config_yaml)
|
|
if 'auth_url' in config_param:
|
|
raise exceptions.TackerClientException(message='Auth URL cannot '
|
|
'be updated',
|
|
status_code=404)
|
|
vim_obj = body[self.resource]
|
|
vim_utils.args2body_vim(config_param, vim_obj)
|
|
tackerV10.update_dict(parsed_args, body[self.resource],
|
|
['tenant_id', 'name', 'description',
|
|
'is_default'])
|
|
return body
|
|
|
|
|
|
class DeleteVIM(tackerV10.DeleteCommand):
|
|
"""Delete given VIM(s)."""
|
|
resource = _VIM
|