openstack/python-tripleoclient
Code Issues Proposed changes

Exclude empty string from no_proxy

Browse Source 
The no_proxy environment can exist with an empty value, and it should
be ignored when generating no_proxy setting.

Change-Id: I497e5caa4ccb9a649f89ebe2cfb98c43505a4445
Closes-Bug: #1968958
This commit is contained in:
Takashi Kajinami 2022-04-14 13:51:16 +09:00
parent ebe72e7056
commit 2231afdb4d
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
tripleoclient/v1/overcloud_deploy.py
View File

@ -445,8 +445,7 @@ class DeployOvercloud(command.Command):
no_proxy_list = map(utils.bracket_ipv6,
[no_proxy, overcloud_ip_or_fqdn,
keystone_admin_ip])
os.environ['no_proxy'] = ','.join(
[x for x in no_proxy_list if x is not None])
os.environ['no_proxy'] = ','.join([x for x in no_proxy_list if x])
utils.remove_known_hosts(overcloud_ip_or_fqdn)