From 43bfc1fb96963e8ab88c6f7bafc52ce1ced228e2 Mon Sep 17 00:00:00 2001 From: James Slagle Date: Tue, 28 Jun 2022 06:44:45 -0400 Subject: [PATCH] Default working_dir for overcloud credential command parsed_args.working_dir was not defaulted to a value when it was not specified, leading to a traceback. Change-Id: I40073c57a7ca283ae913bd78c248bc4cf56da3a8 Signed-off-by: James Slagle --- tripleoclient/v1/overcloud_credentials.py | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/tripleoclient/v1/overcloud_credentials.py b/tripleoclient/v1/overcloud_credentials.py index d61d50cf4..a79a5d08a 100644 --- a/tripleoclient/v1/overcloud_credentials.py +++ b/tripleoclient/v1/overcloud_credentials.py @@ -47,11 +47,15 @@ class OvercloudCredentials(command.Command): def take_action(self, parsed_args): self.log.debug("take_action(%s)" % parsed_args) + if not parsed_args.working_dir: + working_dir = utils.get_default_working_dir(parsed_args.stack) + else: + working_dir = parsed_args.working_dir rc_params = utils.get_rc_params( - parsed_args.working_dir) - endpoint = utils.get_overcloud_endpoint(parsed_args.working_dir) + working_dir) + endpoint = utils.get_overcloud_endpoint(working_dir) admin_vip = utils.get_stack_saved_output_item( - 'KeystoneAdminVip', parsed_args.working_dir) + 'KeystoneAdminVip', working_dir) deployment.create_overcloudrc( parsed_args.stack, endpoint, admin_vip, rc_params, output_dir=parsed_args.directory)