From 71420abff0f1696067cd96d056dd13b1015758cc Mon Sep 17 00:00:00 2001 From: Takashi Kajinami Date: Thu, 14 Apr 2022 13:51:16 +0900 Subject: [PATCH] Exclude empty string from no_proxy The no_proxy environment can exist with an empty value, and it should be ignored when generating no_proxy setting. Change-Id: I497e5caa4ccb9a649f89ebe2cfb98c43505a4445 Closes-Bug: #1968958 (cherry picked from commit 2231afdb4d59e1a8b9a626c4bd4e4a9df879fea4) --- tripleoclient/v1/overcloud_deploy.py | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/tripleoclient/v1/overcloud_deploy.py b/tripleoclient/v1/overcloud_deploy.py index 9796e5847..6e0f0b04c 100644 --- a/tripleoclient/v1/overcloud_deploy.py +++ b/tripleoclient/v1/overcloud_deploy.py @@ -412,8 +412,7 @@ class DeployOvercloud(command.Command): no_proxy_list = map(utils.bracket_ipv6, [no_proxy, overcloud_ip_or_fqdn, keystone_admin_ip]) - os.environ['no_proxy'] = ','.join( - [x for x in no_proxy_list if x is not None]) + os.environ['no_proxy'] = ','.join([x for x in no_proxy_list if x]) utils.remove_known_hosts(overcloud_ip_or_fqdn)