openstack
/
python-tripleoclient
Code Issues Proposed changes

Update patch set 1 

Patch Set 1:

(3 comments)

Patch-set: 1
CC: Gerrit User 16643 <16643@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Attention: {"person_ident":"Gerrit User 34598 \u003c34598@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_25402\u003e replied on the change"}
This commit is contained in:
Gerrit User 25402 2023-12-22 17:01:08 +00:00 committed by Gerrit Code Review
parent c498821ddc
commit 3369087018
1 changed files with 55 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

55
f7cc1e6e2b30d3682e76122763dd0ecf26c651b1 Normal file
View File

@ -0,0 +1,55 @@
{
"comments": [
{
"unresolved": false,
"key": {
"uuid": "f865a5f4_f0f4978c",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 1
},
"lineNbr": 0,
"author": {
"id": 25402
},
"writtenOn": "2023-12-22T17:01:08Z",
"side": 1,
"message": "The overall direction is correct, I suspect that with a good amount of testing this change will be ready soon!",
"revId": "f7cc1e6e2b30d3682e76122763dd0ecf26c651b1",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "3782552e_d920a5bf",
"filename": "tripleoclient/utils.py",
"patchSetId": 1
},
"lineNbr": 1155,
"author": {
"id": 25402
},
"writtenOn": "2023-12-22T17:01:08Z",
"side": 1,
"message": "why `bool(cephfs_filesystem_name)` ? Is this needed to check that is not None?\nIsn\u0027t in that case sufficient if cephfs_filesystem_name?",
"revId": "f7cc1e6e2b30d3682e76122763dd0ecf26c651b1",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "263c057a_91b96a6b",
"filename": "tripleoclient/v1/overcloud_deploy.py",
"patchSetId": 1
},
"lineNbr": 329,
"author": {
"id": 25402
},
"writtenOn": "2023-12-22T17:01:08Z",
"side": 1,
"message": "maybe call this function `validate_cephfs_name`, otherwise the name can be misleading",
"revId": "f7cc1e6e2b30d3682e76122763dd0ecf26c651b1",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}