openstack
/
python-tripleoclient
Code Issues Proposed changes

Merge "Adds new "--no-inflight-validations" option to deploy CLI"

This commit is contained in:
Zuul 2019-08-28 21:47:04 +00:00 committed by Gerrit Code Review
parent 2e0b19ce10 bf48dbc844
commit 3d469a15ed
2 changed files with 16 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
releasenotes/notes/inflight-validation-option-9e3f70b5bcb8dea9.yaml Normal file
View File

@ -0,0 +1,5 @@
---
features:
- |
Introduce new "--no-inflight-validations" option in order to deactivate
those validations. It defaults to "False", since we want them by default.

15
tripleoclient/v1/overcloud_deploy.py
View File

@ -755,6 +755,16 @@ class DeployOvercloud(command.Command):
'use the --run-validations flag. These validations are '
'now run via the external validations in '
'tripleo-validations.'))
parser.add_argument(
'--no-inflight-validations',
action='store_true',
default=False,
dest='no_inflight',
help=_('Deactivate in-flight validations during the deploy. '
'In-flight validations provide a robust way to ensure '
'deployed services are running right after their '
'activation. Defaults to False.')
)
parser.add_argument(
'--dry-run',
action='store_true',
@ -952,9 +962,6 @@ class DeployOvercloud(command.Command):
deployment_options['ansible_python_interpreter'] = \
parsed_args.deployment_python_interpreter
disabled_val = parsed_args.disable_validations
enable_val = parsed_args.run_validations
deployment.config_download(
self.log, self.clients, stack,
parsed_args.templates, parsed_args.overcloud_ssh_user,
@ -965,7 +972,7 @@ class DeployOvercloud(command.Command):
timeout,
verbosity=self.app_args.verbose_level,
deployment_options=deployment_options,
in_flight_validations=(enable_val or not disabled_val))
in_flight_validations=(not parsed_args.no_inflight))
except Exception:
deployment.set_deployment_status(
self.clients, 'failed',