Update patch set 5

Patch Set 5:

(2 comments)

Patch-set: 5
Attention: {"person_ident":"Gerrit User 9816 \u003c9816@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_9816\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 30073 \u003c30073@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_9816\u003e replied on the change"}

229f89f4354d04f6d484b42673a4fd1e0f355427

@@ -57,6 +57,30 @@
       "revId": "229f89f4354d04f6d484b42673a4fd1e0f355427",
       "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
     },
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "059f9dd3_f34d37e7",
+        "filename": "tripleoclient/v1/overcloud_update.py",
+        "patchSetId": 5
+      },
+      "lineNbr": 102,
+      "author": {
+        "id": 9816
+      },
+      "writtenOn": "2023-03-07T06:02:50Z",
+      "side": 1,
+      "message": "+1. skiplist is not an external interface so we should refer to DeploymentServerBlacklist instead.",
+      "parentUuid": "5ba97af7_76c87c4a",
+      "range": {
+        "startLine": 100,
+        "startChar": 0,
+        "endLine": 102,
+        "endChar": 37
+      },
+      "revId": "229f89f4354d04f6d484b42673a4fd1e0f355427",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
+    },
     {
       "unresolved": true,
       "key": {
@@ -79,6 +103,30 @@
       },
       "revId": "229f89f4354d04f6d484b42673a4fd1e0f355427",
       "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
+    },
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "039070e0_f3c63bee",
+        "filename": "tripleoclient/v1/overcloud_update.py",
+        "patchSetId": 5
+      },
+      "lineNbr": 204,
+      "author": {
+        "id": 9816
+      },
+      "writtenOn": "2023-03-07T06:02:50Z",
+      "side": 1,
+      "message": "Although we can add the expression to exclude the excluded_overcloud always, I tend to agree with the warning which also contains list of node names. In case a node is blacklisted then the node is not updated. Users should be aware of that fact, otherwise they might leave some node with older version.\n\nAlso, does it makes sense to make the logic fail if user gives a specific node which is blacklisted ? That would also make the use aware of the fact the request can\u0027t be fulfilled.",
+      "parentUuid": "5d8e3a95_a61cccef",
+      "range": {
+        "startLine": 199,
+        "startChar": 0,
+        "endLine": 204,
+        "endChar": 62
+      },
+      "revId": "229f89f4354d04f6d484b42673a4fd1e0f355427",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
     }
   ]
 }