openstack
/
python-tripleoclient
Code Issues Proposed changes

Validate routed networks enabled if multiple subnets in conf 

Add's a validation to undercloud preflight checks to ensure
eneble_routed_networks is True when multiple subnets is defined
in undercloud.conf.

Change-Id: I48ea4d70bf79c622f037469fa6d82eea7524b835
Closes-Bug: #1791034
This commit is contained in:
Harald Jensås 2018-09-06 12:15:00 +02:00
parent 01eca26528
commit 3f584233a5
1 changed files with 9 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
tripleoclient/v1/undercloud_preflight.py
View File

@ -486,6 +486,14 @@ def _checking_status(item):
LOG.info(_('Checking %s...') % item)
def _check_routed_networks_enabled_if_multiple_subnets_defined():
if (len(CONF.subnets) > 1 and not CONF.enable_routed_networks):
msg = _('Multiple subnets specified: %s but routed networks are not '
'enabled.') % CONF.subnets
LOG.error(msg)
raise FailedValidation(msg)
def check(verbose_level, upgrade=False):
# Fetch configuration and use its log file param to add logging to a file
utils.load_config(CONF, constants.UNDERCLOUD_CONF_PATH)
@ -511,6 +519,7 @@ def check(verbose_level, upgrade=False):
# Networking validations
_checking_status('Networking values')
_validate_value_formats()
_check_routed_networks_enabled_if_multiple_subnets_defined()
for subnet in CONF.subnets:
s = CONF.get(subnet)
_checking_status('Subnet "%s" is in CIDR' % subnet)