openstack/python-tripleoclient
Code Issues Proposed changes

Deprecate 'overcloud profiles' commands

Browse Source 
Since we do not use nova on the undercloud by default
let's add a deprecation warning for removal of the commands.

Change-Id: I58f7b3dc111fc930ebbffa8389d0bf222d3239b4
This commit is contained in:
Harald Jensås 2022-01-19 03:35:55 +01:00
parent 466b5a3adf
commit 482b0acd0d
2 changed files with 18 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
releasenotes/notes/deprecate-overcloud-profiles-0bc0a368775844ad.yaml Normal file
View File

@ -0,0 +1,8 @@
---
deprecations:
- |
The commands ``openstack overcloud profiles list`` and ``openstack
overcloud profiles match`` has been deprecated for removal. Since the
Compute service is no longer used on the undercloud, the flavors based
scheduling is not used.

10
tripleoclient/v1/overcloud_profiles.py
View File

@ -20,6 +20,12 @@ from tripleoclient import command
from tripleoclient import exceptions
from tripleoclient import utils
DEPRECATION_MSG = '''
This command has been DEPRECATED and will be removed. The compute service is no
longer used on the undercloud by default, hence profile matching with compute
flavors is no longer used.
'''
class MatchProfiles(command.Command):
"""Assign and validate profiles on nodes"""
@ -28,6 +34,7 @@ class MatchProfiles(command.Command):
def get_parser(self, prog_name):
parser = super(MatchProfiles, self).get_parser(prog_name)
parser.epilog = DEPRECATION_MSG
parser.add_argument(
'--dry-run',
action='store_true',
@ -39,6 +46,7 @@ class MatchProfiles(command.Command):
def take_action(self, parsed_args):
self.log.debug("take_action(%s)" % parsed_args)
self.log.warning(DEPRECATION_MSG)
bm_client = self.app.client_manager.baremetal
flavors = self._collect_flavors(parsed_args)
@ -92,6 +100,7 @@ class ListProfiles(command.Lister):
def get_parser(self, prog_name):
parser = super(ListProfiles, self).get_parser(prog_name)
parser.epilog = DEPRECATION_MSG
parser.add_argument(
'--all',
action='store_true',
@ -103,6 +112,7 @@ class ListProfiles(command.Lister):
def take_action(self, parsed_args):
self.log.debug("take_action(%s)" % parsed_args)
self.log.warning(DEPRECATION_MSG)
bm_client = self.app.client_manager.baremetal
compute_client = self.app.client_manager.compute