openstack
/
python-tripleoclient
Code Issues Proposed changes

(UX) Improve logging if the ephemeral heat stack wasn't created 

If the ephemeral heat stack wasn't created, raise a proper error message
explaining what happens and how to proceed instead of a python stack
trace.

Change-Id: I4c2e19e290751ea56f1b45aaebc56ea9a5d2c6d1
Closes-Bug: #1892248
(cherry picked from commit 686ac839b4)
This commit is contained in:
Emilien Macchi 2020-08-19 16:40:18 -04:00
parent b02ed76dcc
commit 79bb147bb9
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
tripleoclient/v1/tripleo_deploy.py
View File

@ -825,8 +825,13 @@ class Deploy(command.Command):
self.log.warning(_("** Performing Heat stack create.. **"))
stack = orchestration_client.stacks.create(**stack_args)
stack_id = stack['stack']['id']
if not stack:
msg = _('The ephemeral Heat stack could not be created, please '
'check logs in /var/log/heat-launcher and/or any '
'possible misconfiguration.')
raise exceptions.DeploymentError(msg)
stack_id = stack['stack']['id']
return "%s/%s" % (stack_name, stack_id)
def _download_ansible_playbooks(self, client, stack_name,