From 7b290d41b00ddfa3f241784efceda1831134bac3 Mon Sep 17 00:00:00 2001 From: "Gael Chamoulaud (Strider)" Date: Wed, 13 Oct 2021 11:47:55 +0200 Subject: [PATCH] Fix the validations_log_basedir overriding The patch [1] doesn't work and the validations execution logs are located in /home/stack/validations by default instead of /var/log/validations directory. This patch fixes this issue by overriding correctly the 'validation_log_dir' default value for the run, show history and show run sub commands. [1] https://review.opendev.org/c/openstack/python-tripleoclient/+/794577 Related-bz: rhbz#2013575 Signed-off-by: Gael Chamoulaud (Strider) Change-Id: Ic9de63514086d660cfbe87ef6539935366036941 --- tripleoclient/v1/tripleo_validator.py | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/tripleoclient/v1/tripleo_validator.py b/tripleoclient/v1/tripleo_validator.py index 1601d7c0d..da728cd1b 100644 --- a/tripleoclient/v1/tripleo_validator.py +++ b/tripleoclient/v1/tripleo_validator.py @@ -74,8 +74,8 @@ class TripleOValidatorRun(Run): def get_parser(self, parser): parser = super(TripleOValidatorRun, self).get_parser(parser) - parser.set_defaults( - validations_log_dir=constants.VALIDATIONS_LOG_BASEDIR) + default = {'validation_log_dir': constants.VALIDATIONS_LOG_BASEDIR} + parser.set_defaults(**default) return parser @@ -86,8 +86,8 @@ class TripleOValidatorShowHistory(ListHistory): def get_parser(self, parser): parser = super(TripleOValidatorShowHistory, self).get_parser(parser) - parser.set_defaults( - validations_log_dir=constants.VALIDATIONS_LOG_BASEDIR) + default = {'validation_log_dir': constants.VALIDATIONS_LOG_BASEDIR} + parser.set_defaults(**default) return parser @@ -98,6 +98,6 @@ class TripleOValidatorShowRun(GetHistory): def get_parser(self, parser): parser = super(TripleOValidatorShowRun, self).get_parser(parser) - parser.set_defaults( - validations_log_dir=constants.VALIDATIONS_LOG_BASEDIR) + default = {'validation_log_dir': constants.VALIDATIONS_LOG_BASEDIR} + parser.set_defaults(**default) return parser