openstack
/
python-tripleoclient
Code Issues Proposed changes

Fix the validations_log_basedir overriding 

The patch [1] doesn't work and the validations execution logs are
located in /home/stack/validations by default instead of
/var/log/validations directory.

This patch fixes this issue by overriding correctly the
'validation_log_dir' default value for the run, show history and show
run sub commands.

[1] https://review.opendev.org/c/openstack/python-tripleoclient/+/794577

Related-bz: rhbz#2013575
Signed-off-by: Gael Chamoulaud (Strider) <gchamoul@redhat.com>
Change-Id: Ic9de63514086d660cfbe87ef6539935366036941
This commit is contained in:
Gael Chamoulaud (Strider) 2021-10-13 11:47:55 +02:00 committed by Gael Chamoulaud
parent d21d177320
commit 7b290d41b0
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
tripleoclient/v1/tripleo_validator.py
View File

@ -74,8 +74,8 @@ class TripleOValidatorRun(Run):
def get_parser(self, parser): def get_parser(self, parser):
parser = super(TripleOValidatorRun, self).get_parser(parser) parser = super(TripleOValidatorRun, self).get_parser(parser)
parser.set_defaults( default = {'validation_log_dir': constants.VALIDATIONS_LOG_BASEDIR}
validations_log_dir=constants.VALIDATIONS_LOG_BASEDIR) parser.set_defaults(**default)
return parser return parser
@ -86,8 +86,8 @@ class TripleOValidatorShowHistory(ListHistory):
def get_parser(self, parser): def get_parser(self, parser):
parser = super(TripleOValidatorShowHistory, self).get_parser(parser) parser = super(TripleOValidatorShowHistory, self).get_parser(parser)
parser.set_defaults( default = {'validation_log_dir': constants.VALIDATIONS_LOG_BASEDIR}
validations_log_dir=constants.VALIDATIONS_LOG_BASEDIR) parser.set_defaults(**default)
return parser return parser
@ -98,6 +98,6 @@ class TripleOValidatorShowRun(GetHistory):
def get_parser(self, parser): def get_parser(self, parser):
parser = super(TripleOValidatorShowRun, self).get_parser(parser) parser = super(TripleOValidatorShowRun, self).get_parser(parser)
parser.set_defaults( default = {'validation_log_dir': constants.VALIDATIONS_LOG_BASEDIR}
validations_log_dir=constants.VALIDATIONS_LOG_BASEDIR) parser.set_defaults(**default)
return parser return parser