openstack
/
python-tripleoclient
Code Issues Proposed changes

Remove excessive output when configuring nodes 

The legacy 'baremetal configure boot' command calls the 'configure'
workflow individually for each node, causing a success/failure message
to be printed each time. The configured node UUID(s) are included in
the execution output, so printing a specific message for each node is
possible. However, considering that with many nodes this would make it
easy for failure messages to go unnoticed, and that the command prior
to the Mistral migration had no output, this patch removes the message
when nothing went wrong instead.

Change-Id: I3f1df8046ad92328fe0ee47fa073c58ca9ad5f20
Closes-Bug: #1619717
This commit is contained in:
Julie Pichon 2016-09-06 11:26:27 +01:00
parent 3093ca2e61
commit 824620cc8b
1 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
tripleoclient/workflows/baremetal.py
View File

@ -192,9 +192,7 @@ def configure(clients, **workflow_input):
with ooo_client.messaging_websocket(queue_name) as ws:
payload = ws.wait_for_message(execution.id)
if payload['status'] == 'SUCCESS':
print('Successfully configured all nodes.')
else:
if payload['status'] != 'SUCCESS':
raise exceptions.NodeConfigurationError(
'Failed to configure nodes: {}'.format(payload['message']))