openstack/python-tripleoclient
Code Issues Proposed changes

Replace 'raise StopIteration' with 'return'

Browse Source 
With PEP 479, the behaviour of StopIteration is changing. Raising it to
stop a generator is considered incorrect and from Python 3.7 this will
cause a RuntimeError. The PEP recommends using the return statement.

More details: https://www.python.org/dev/peps/pep-0479/#examples-of-breakage

Change-Id: I7b35bc0525b599950a7fa0e58caeffcedb6bd18b
This commit is contained in:
Dougal Matthews
2018-06-29 11:23:07 +01:00
parent e70d027d53
commit 9f3cbf7706
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
tripleoclient/workflows/base.py
View File

@@ -71,7 +71,7 @@ def wait_for_messages(mistral, websocket, execution, timeout=None):
# Workflows should end with SUCCESS or ERROR statuses. # Workflows should end with SUCCESS or ERROR statuses.
if payload.get('status', 'RUNNING') != "RUNNING" or \ if payload.get('status', 'RUNNING') != "RUNNING" or \
mistral.executions.get(execution.id).state != "RUNNING": mistral.executions.get(execution.id).state != "RUNNING":
raise StopIteration return
except exceptions.WebSocketTimeout: except exceptions.WebSocketTimeout:
check_execution_status(mistral, execution.id) check_execution_status(mistral, execution.id)
raise raise