diff --git a/releasenotes/notes/ipmi-lanplus-default-fb3ec3496853ed9e.yaml b/releasenotes/notes/ipmi-lanplus-default-fb3ec3496853ed9e.yaml new file mode 100644 index 000000000..1dee5317f --- /dev/null +++ b/releasenotes/notes/ipmi-lanplus-default-fb3ec3496853ed9e.yaml @@ -0,0 +1,6 @@ +--- +features: + - | + Deprecate --ipmi-lanplus for ``openstack overcloud generate fencing`` + command since now this is the default and add new option --ipmi-no-lanplus + to override it. diff --git a/tripleoclient/tests/v1/test_overcloud_parameters.py b/tripleoclient/tests/v1/test_overcloud_parameters.py index b02fe6f1e..5ef53f8ec 100644 --- a/tripleoclient/tests/v1/test_overcloud_parameters.py +++ b/tripleoclient/tests/v1/test_overcloud_parameters.py @@ -166,7 +166,7 @@ class TestGenerateFencingParameters(utils.TestCommand): 'delay': None, 'os_auth': {}, 'ipmi_cipher': None, - 'ipmi_lanplus': False, + 'ipmi_lanplus': True, 'ipmi_level': None }, run_sync=True, save_result=True) diff --git a/tripleoclient/v1/overcloud_parameters.py b/tripleoclient/v1/overcloud_parameters.py index ea95a1d5d..9861b705f 100644 --- a/tripleoclient/v1/overcloud_parameters.py +++ b/tripleoclient/v1/overcloud_parameters.py @@ -80,8 +80,14 @@ class GenerateFencingParameters(command.Command): help=_('Wait DELAY seconds before fencing is ' 'started')) parser.add_argument('--ipmi-lanplus', + dest='ipmi_lanplus', + default=True, action='store_true', - help=_('Use Lanplus. Defaults to: false')) + help=_('DEPRECATED: This is the default.')) + parser.add_argument('--ipmi-no-lanplus', + dest='ipmi_lanplus', + action='store_false', + help=_('Do not use Lanplus. Defaults to: false')) parser.add_argument('--ipmi-cipher', type=int, help=_('Ciphersuite to use (same as ipmitool -C ' 'parameter.'))